Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load contract from github #3

Open
jbentke opened this issue Aug 28, 2019 · 5 comments
Open

Load contract from github #3

jbentke opened this issue Aug 28, 2019 · 5 comments

Comments

@jbentke
Copy link

jbentke commented Aug 28, 2019

Would be nice to have a feature to load contracts straight from github like https://github.com/TennaGraph/TennaGraph/blob/master/smart_contracts/contracts/VotingManager.sol

@hai-ko
Copy link

hai-ko commented Aug 28, 2019

@jbentke that is already possible by using url parameters see https://blog.slock.it/analyzing-solidity-smart-contracts-with-piet-6db33a733e79 e.g. https://piet.slock.it/?gitHubUser=gnosis&gitHubRepo=safe-contracts&subDir=contracts

@jbentke
Copy link
Author

jbentke commented Aug 28, 2019

a button would be nicer thow instead of messing directly with the url

@hai-ko
Copy link

hai-ko commented Aug 28, 2019

Agreed, I'll add this feature. I did first the URL solution because this makes it possible to send someone a link that directly loads the contracts.

@KoenBal
Copy link

KoenBal commented Dec 16, 2019

Sometimes working in chrome
https://piet.slock.it/?gitHubUser=gnosis&gitHubRepo=safe-contracts&subDir=contracts/common
https://piet.slock.it/?gitHubUser=celo-org&gitHubRepo=celo-monorepo&subDir=packages/protocol/contracts/stability

I often receive the notification:

Error: Request failed with status code 403 while loading the GitHub repository. Are you trying to access a private repository?
or
Error: Request failed with status code 403 while loading the GitHub repository.

While it is obviously not a private repo.

no pop-up or anything in Brave
https://piet.slock.it/?gitHubUser=celo-org&gitHubRepo=celo-monorepo&subDir=packages/protocol/contracts/stability

@KoenBal
Copy link

KoenBal commented Dec 16, 2019

Oke, it seems related to the GitHub rate limit

documentation_url: "https://developer.github.com/v3/#rate-limiting"
message: "API rate limit exceeded for 92.223.89.138. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants