Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: open dapp info for external dapps #2454

Closed
yvaskov opened this issue Dec 9, 2024 · 1 comment · Fixed by #2567
Closed

Search: open dapp info for external dapps #2454

yvaskov opened this issue Dec 9, 2024 · 1 comment · Fixed by #2567
Labels
pre-release Tasks in pre-release right now

Comments

@yvaskov
Copy link
Contributor

yvaskov commented Dec 9, 2024

Description

Currently clicking an external dapp in the search results leads to an external page. The proposal is to open More info modal of the selected dapp on the DAppscout page.
@varunguleriaCodes
Copy link
Contributor

Hi @yvaskov I will like to work on this. Just few queries:

  1. In ui 3.6(5) what is 5 here which field should be targeted.
  2. What should be the functionality of heart button and share button(just copy the website link)?

@varunguleriaCodes varunguleriaCodes mentioned this issue Jan 1, 2025
Merged
@isstuev isstuev mentioned this issue Feb 10, 2025
Merged
@github-actions github-actions bot added the pre-release Tasks in pre-release right now label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pre-release Tasks in pre-release right now
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Search: open dapp info for external dapps fix blockscout/frontend
2 participants
@yvaskov @varunguleriaCodes