Reduce public API before release. #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #510 |
|
One build passed, two failed on random failures. Re-running those just to be sure. |
|
Looks good to me |
gwbischof
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many utility methods in
corethat were written in prep for arefactor of
databroker_to_xarray, some of which are not actually used yet,and maybe all of which could be moved to
event-modelbecause they aregenerically useful for manipulating Documents. In prepartion for possibly
moving and/or re-tooling them, I have made them private except for those
that are imported to drivers.
I also moved
tail, which a text-parsing utility only used by the JSONL driver,into the JSONL driver.