Fix use of default context in caproto shim #1238
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: To be merged after (and only if) caproto/caproto#862 is merged and released.
Uses the default context as a cached class method rather than the instance method that was released in https://github.com/caproto/caproto/releases/tag/v1.2.0
It also ensures that a different context is not passed in to the
get_pvfunction so that the same context is used by caproto as is used by the event dispatcher.Ophyd can't make its own default context unless it overrides and monkey-patches the remaining
pyepics_compatfunctions. We only overrideget_pvright now:ophyd/ophyd/_caproto_shim.py
Lines 188 to 189 in be3a514
Please let me know if I am missing something here!