-
-
Notifications
You must be signed in to change notification settings - Fork 293
FE - Font-sizes should adjust to user settings #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Are there any SaaS projects that do this so I can check? And how does one change the user's settings so the app respects it? |
Forget what I said earlier :) I’ve watched two videos and feel I got the point. I just suggest we prioritize addressing small bugs and building our infrastructure monitoring first. After we launch version 2.0, we can tackle this issue. What do you think? |
I'm on board for this issue after @marcelluscaio 's presentation this morning 👍 After infrastructure monitoring we can work on this and perhaps the big boogeyman, responsive design 👻 |
Hello ! Is this issue still relevant and can I be assigned to this if it is the case? |
Hello @blastoncrush - sure, it's still relevant. Can you please give us some more information about what you are going to do, very shortly, so we are all on the same page? |
Hello @gorkem-bwl ! Thanks for the quick answer. I think I will start by changing all px sizes by equivalent rem size (using a converter), starting by this file : https://github.com/bluewave-labs/Checkmate/blob/develop/src/index.css |
Let's go! :) |
I have automated the task by using a python programm and using the conversion 1rem = 16px |
Hi @blastoncrush , I see your open PR on this, however we are moving away from using CSS at all. Fonts are set in the theme and should not be overridden by CSS:
All that should be required to set the font size on a per user basis should be to make the All CSS set font sizes should be removed entirely really. Relevant docs here |
Hello @ajhollid, thanks for the answer. I don't understand the issue : in the code you show, fonts are declared using rem, not px |
In the file your talking about (
|
Is your feature request related to a problem? Please describe.
Fonts are declared using px, and that does not respect user's settings, violating WCAG Success Criterion 1.4.4 (https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-scale.html_
Describe the solution you'd like
Fonts can be declared using the REM unit
Describe alternatives you've considered
I cannot think of an alternative.
The text was updated successfully, but these errors were encountered: