-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/.vitepress >> custom base path & root #34
Comments
Amazing repro and description! That makes sense to me. So we need to prepend the base here: whyframe/packages/core/src/plugins/api.js Lines 84 to 88 in 4c2f05f
And I think we can borrow the base from the Vite config using the Would you like to send a PR? I'm able to fix this later too if not. |
I'm sorry, but I can't do it in the near future |
Ok. I add PR #35 |
Thanks for fixing it. I actually did locally but found some other issues that made base not working (and then forgotten to follow up), but anyways it's probably good enough to get some fixes out first. I'll merge your PR and cut a release. |
Hello.
Project Structure
![error-whyframe](https://private-user-images.githubusercontent.com/167157537/367157739-e1a3f697-5dc1-460e-ad82-117f3f865312.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0OTE3MDUsIm5iZiI6MTczOTQ5MTQwNSwicGF0aCI6Ii8xNjcxNTc1MzcvMzY3MTU3NzM5LWUxYTNmNjk3LTVkYzEtNDYwZS1hZDgyLTExN2YzZjg2NTMxMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQwMDAzMjVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iYTk4MWNkYjRjMzkwM2ZmYjNhNGM5YWYyZjk0ODk4MTBkZjZiODU2ZmE4MDgzZDE4MmI0OWM1OTc0ZWZkNWJkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.zv-IYP9M1RUl5BVl2ceOGBNzv-6Irqd2f1WJXsmwQuw)
The documentation is created using VitePress and is located in the
/docs
folder.The project documentation will be published at
https://demo.com/my-demo-folder/
In other words, the path is built relative to the '/my-demo-folder/' folder.
Config
docs/.vitepress/config.mts
With this configuration, there is an issue
![error-whyframe-2](https://private-user-images.githubusercontent.com/167157537/367158652-73c83632-7257-4299-8502-677a180c3064.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0OTE3MDUsIm5iZiI6MTczOTQ5MTQwNSwicGF0aCI6Ii8xNjcxNTc1MzcvMzY3MTU4NjUyLTczYzgzNjMyLTcyNTctNDI5OS04NTAyLTY3N2ExODBjMzA2NC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQwMDAzMjVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03OGMyYTE5ZjljNmRlOWY1OWU2NjExOTU2ZTAwY2JjZjA2ZDE0OGViYjI4ZTcxZDQzYTc5MjdjMGFkZjcxM2VjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ZOAVldMm0gIXUmk2kCluX0flGG6O8GlcGrFpkJ8VZZU)
If you build the project and view it, everything works
![error-whyframe-3](https://private-user-images.githubusercontent.com/167157537/367159038-56726d9c-659e-4e6a-8331-a7674965b24e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0OTE3MDUsIm5iZiI6MTczOTQ5MTQwNSwicGF0aCI6Ii8xNjcxNTc1MzcvMzY3MTU5MDM4LTU2NzI2ZDljLTY1OWUtNGU2YS04MzMxLWE3Njc0OTY1YjI0ZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQwMDAzMjVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kZjk5MzYwZGMyMmVhMmI2MGYxYjM1MjU5N2UzOTY4NTQ3ZDU5M2E0OWI1OWU2NWVjZWE3MDk3MjAyNTY4OWRkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.LSEhrTFZWaR0GVZrkkHMrAQeDA-tJ9tRKIknTq_y8P0)
The essence of the problem is in this code
![error-whyframe-fix](https://private-user-images.githubusercontent.com/167157537/367159720-a1b681b7-bc9b-4960-9788-764296e0c2c2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0OTE3MDUsIm5iZiI6MTczOTQ5MTQwNSwicGF0aCI6Ii8xNjcxNTc1MzcvMzY3MTU5NzIwLWExYjY4MWI3LWJjOWItNDk2MC05Nzg4LTc2NDI5NmUwYzJjMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQwMDAzMjVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iNjk0NWU2YjNhYmZiMzM2NDBmOGJkNjA1Nzk1MTgxZGVjYjJiN2ZiYmYyODNlNjk0ODVkMzE3ODllOWQ3ZDNlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.qmqP6-efRh6U6lDI7dauRlvE_vZX_9aToDxcfE5Fm58)
With this approach, it will work
![error-whyframe-4](https://private-user-images.githubusercontent.com/167157537/367159991-28569c00-d852-48d7-9ed9-8894f0f354bc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0OTE3MDUsIm5iZiI6MTczOTQ5MTQwNSwicGF0aCI6Ii8xNjcxNTc1MzcvMzY3MTU5OTkxLTI4NTY5YzAwLWQ4NTItNDhkNy05ZWQ5LTg4OTRmMGYzNTRiYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQwMDAzMjVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jNTQzMGJiNDRkOTJiNmQ0ZDAxMjVkNzg0OTllODFjYjRkZjNhYTU4N2FmYjVjNjA4NWVmNTM4ZDY5NjA5ZDU2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Yz0qhFC5Ensk6iCW9ni8xtyI80Fiu-xt5_i1JjgIRAk)
The text was updated successfully, but these errors were encountered: