Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from KelvinTegelaar:main #112

Merged
merged 10 commits into from
Feb 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .github/workflows/cipp_dev_build.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
name: CIPP Frontend Build
name: CIPP Frontend Dev Build

on:
push:
branches:
- dev
workflow_dispatch:

permissions:
contents: write

jobs:
build:
if: github.event.repository.fork == false
Expand All @@ -18,11 +15,11 @@ jobs:
steps:
# Checkout the repository
- name: Checkout Code
uses: actions/checkout@v3
uses: actions/checkout@v4.2.2

# Set up Node.js
- name: Set up Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4.2.0
with:
node-version: '20.18.1'

Expand All @@ -43,7 +40,7 @@ jobs:

# Upload to Azure Blob Storage
- name: Azure Blob Upload
uses: LanceMcCarthy/Action-AzureBlobUpload@v3.3.0
uses: LanceMcCarthy/Action-AzureBlobUpload@v3.3.1
with:
connection_string: ${{ secrets.AZURE_CONNECTION_STRING }}
container_name: cipp
Expand Down
10 changes: 3 additions & 7 deletions .github/workflows/cipp_frontend_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ on:
- main
workflow_dispatch:

permissions:
contents: write

jobs:
build:
if: github.event.repository.fork == false
Expand All @@ -18,11 +15,11 @@ jobs:
steps:
# Checkout the repository
- name: Checkout Code
uses: actions/checkout@v3
uses: actions/checkout@v4.2.2

# Set up Node.js
- name: Set up Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4.2.0
with:
node-version: '20.18.1'

Expand All @@ -43,11 +40,10 @@ jobs:

# Upload to Azure Blob Storage
- name: Azure Blob Upload
uses: LanceMcCarthy/Action-AzureBlobUpload@v3.3.0
uses: LanceMcCarthy/Action-AzureBlobUpload@v3.3.1
with:
connection_string: ${{ secrets.AZURE_CONNECTION_STRING }}
container_name: cipp
source_folder: build/
destination_folder: /
delete_if_exists: true

2 changes: 1 addition & 1 deletion public/version.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"version": "7.2.2"
"version": "7.2.3"
}
3 changes: 2 additions & 1 deletion src/components/CippComponents/CippFormTenantSelector.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { CippFormComponent } from "./CippFormComponent";

export const CippFormTenantSelector = ({
formControl,
componentType='autoComplete',
allTenants = false,
type = "multiple",
name = "tenantFilter",
Expand All @@ -23,7 +24,7 @@ export const CippFormTenantSelector = ({

return (
<CippFormComponent
type="autoComplete"
type={componentType}
name={name}
formControl={formControl}
placeholder="Select a tenant"
Expand Down
2 changes: 1 addition & 1 deletion src/components/CippFormPages/CippFormPage.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ const CippFormPage = (props) => {
<Stack spacing={2} direction="row">
{addedButtons && addedButtons}
<Button
disabled={postCall.isPending || !isValid || (!allowResubmit && !isDirty)}
disabled={postCall.isPending || !isValid || (!allowResubmit && (!isDirty))}
onClick={formControl.handleSubmit(handleSubmit)}
type="submit"
variant="contained"
Expand Down
2 changes: 1 addition & 1 deletion src/components/CippTable/util-columnsFromAPI.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { getCippFilterVariant } from "../../utils/get-cipp-filter-variant";
import { getCippFormatting } from "../../utils/get-cipp-formatting";
import { getCippTranslation } from "../../utils/get-cipp-translation";

const skipRecursion = ["location"];
const skipRecursion = ["location", "ScheduledBackupValues"];
// Function to merge keys from all objects in the array
const mergeKeys = (dataArray) => {
return dataArray.reduce((acc, item) => {
Expand Down
3 changes: 1 addition & 2 deletions src/components/CippWizard/CIPPDeploymentStep.js
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,7 @@ export const CippDeploymentStep = (props) => {
placeholder="Enter the application secret. Leave blank to retain previous key."
validators={{
validate: (value) => {
const secretRegex =
/^(?![0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$)[0-9a-zA-Z]{40}$/;
const secretRegex = /^(?!^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$)[A-Za-z0-9-_~.]{20,}$/;
return (
value === "" ||
secretRegex.test(value) ||
Expand Down
Loading