Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser error in file "common/version.scad" #207

Closed
alnavv opened this issue Feb 6, 2020 · 8 comments
Closed

Parser error in file "common/version.scad" #207

alnavv opened this issue Feb 6, 2020 · 8 comments

Comments

@alnavv
Copy link

alnavv commented Feb 6, 2020

[ ERROR ]
ERROR: Parser error in file "/tmp/common/version.scad", line 1: syntax error
ERROR: Compilation failed

[ WORKING ENVIRONMENT ]
openscad in docker, and all the libraries inside the docker image (/LIBS/BOLTS, )
From the openscad Help/Library Info:
OPENSCADPATH: /LIBS:/LIBS/BOLTS
OpenSCAD library path:
/LIBS
/LIBS/BOLTS

in my host, i have the file:
/tmp/test.scad
with "ONLY":
include <BOLTS.scad>
so i open this file using the container and get the described error.

NOTE: All the other libraries work fine (NopScadLib, dotSCAD, BOSL, etc ..)

@Brandano
Copy link

Pretty sure this is STILL the same issue I opened three years ago:
#174
Just add string delimiters around the licence description string.

@alnavv
Copy link
Author

alnavv commented Feb 12, 2020

Thanks, Brandano, it seems you are right. Just opened the file inside the container and the error was there ... addedd delimiters and the error was gone.
It would be nice to fix this :)

@berndhahnebach
Copy link
Contributor

berndhahnebach commented Oct 19, 2020

I do not use openscad at all. Would one of you go for a PR?

@berndhahnebach
Copy link
Contributor

this might have been fixed already ... https://github.com/boltsparts/BOLTS/blob/da747e25ae66a78d6f1f7b0a1d926ebd3ba12e16/backends/openscad.py#L201 IMHO quotes should be added on openscad BOLTS.

What did you use? Did you download version 0.3 for openscad or did you created the version from BOLTS source code yourself?

bernd

@berndhahnebach
Copy link
Contributor

It actually is fixed. 5f6592b

I may create a uptodate version for openscad but I can not test it, since I do not use it.

@berndhahnebach
Copy link
Contributor

berndhahnebach commented Oct 20, 2020

would you guys test: https://github.com/boltsparts/BOLTS/releases/tag/dd53a1d ?

@Brandano
Copy link

Brandano commented Oct 20, 2020

For the purpose of this bug, it seems to work fine now. I do get an unrelated error in base/hex_socket/hex_socket.scad:
WARNING: Ignoring unknown variable 'h', in file libs/bolts/base/hex_socket/hex_socket.scad, line 48.
Which means that this check is skipped: BOLTS_check_dimension_positive(h,"l too short");
Probably hex_socket_2 is missing one line like line 24 in the module immediately preceding it?
Or maybe the check should be on k, since it's used as h on line 53

@berndhahnebach
Copy link
Contributor

I have created a new issue in this regard ... #220

will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants