Skip to content

Handshake is now more resilient #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 62 commits into from
May 7, 2025
Merged

Conversation

anarthal
Copy link
Collaborator

Errors issued by the server for caching_sha2_password users after a fast auth OK packet has been received (e.g. bad database errors) are now reported correctly
Handshake now correctly detects protocol violation errors, like double auth switches

close #469
close #468

Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 99.39759% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.15%. Comparing base (6839555) to head (40af68a).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ude/boost/mysql/impl/internal/sansio/handshake.hpp 98.87% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #474   +/-   ##
========================================
  Coverage    99.14%   99.15%           
========================================
  Files          142      143    +1     
  Lines         7278     7297   +19     
========================================
+ Hits          7216     7235   +19     
  Misses          62       62           
Files with missing lines Coverage Δ
include/boost/mysql/client_errc.hpp 100.00% <ø> (ø)
include/boost/mysql/impl/error_categories.ipp 98.78% <100.00%> (+0.03%) ⬆️
...t/mysql/impl/internal/protocol/deserialization.hpp 97.31% <100.00%> (-0.39%) ⬇️
...ost/mysql/impl/internal/protocol/static_buffer.hpp 100.00% <100.00%> (ø)
...sql/impl/internal/sansio/caching_sha2_password.hpp 100.00% <100.00%> (ø)
...sql/impl/internal/sansio/connection_state_data.hpp 100.00% <100.00%> (ø)
...sql/impl/internal/sansio/mysql_native_password.hpp 100.00% <100.00%> (ø)
include/boost/mysql/impl/is_fatal_error.ipp 100.00% <100.00%> (ø)
...ude/boost/mysql/impl/internal/sansio/handshake.hpp 99.23% <98.87%> (+0.95%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6839555...40af68a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anarthal anarthal merged commit 90405e7 into develop May 7, 2025
6 checks passed
@anarthal anarthal deleted the feature/469-handshake-hardening branch May 7, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handshake hardening Incorrect error message with caching_sha2_password user triggers a non-password error during handshake
1 participant