Skip to content

Update Antora UI styles #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

julioest
Copy link
Collaborator

Description

This PR is meant to be first iteration of boost doc styling update, giving it a previous look-and-feel ui

Notes

@julioest julioest requested a review from alandefreitas May 24, 2024 20:28
@vinniefalco
Copy link
Member

Where's the preview?

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://234.site-docs.prtest2.cppalliance.org/contributor-guide/index.html

Copy link
Member

@alandefreitas alandefreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinniefalco
Copy link
Member

@alandefreitas how do you know that the preview is showing exactly how it will look on the live server? It already looks different... the preview has Lunr and Search box but those are not present on live.

@alandefreitas
Copy link
Member

how do you know that the preview is showing exactly how it will look on the live server?

I don't. website-v2 is an independent project and I have no idea of what transformations they've implemented there. For all I know, they could even be using another UI bundle.

@vinniefalco
Copy link
Member

Well we better figure this out then, shouldn't we?

@alandefreitas
Copy link
Member

@joaquintides Who understands the process in website-v2 that's patching the documentation with that boost.io header?

@vinniefalco It's a good idea to figure this out because we will need it. Since this PR is about the fonts, I think the header issue is independent of and shouldn't block this PR and @julioest.

@joaquintides
Copy link
Member

@joaquintides Who understands the process in website-v2 that's patching the documentation with that boost.io header?

@julioest has been doing changes to this header laterly, so I guess he's the person you're looking for.

@vinniefalco
Copy link
Member

RevSys understands it. (Frank Wiles)

@alandefreitas
Copy link
Member

@julioest (...) 's the person you're looking for.

Well, that would be ironic 😆

@alandefreitas alandefreitas merged commit 65dfedd into boostorg:develop May 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Antora UI: visual defect when scrolling
5 participants