Skip to content

Update Antora UI template (#266) #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 6, 2024

Conversation

julioest
Copy link
Collaborator

@julioest julioest commented Aug 1, 2024

Description

This PR updates the Antora UI templates to enhance the user interface and improve the overall user experience

Addresses #266

@julioest julioest requested a review from alandefreitas August 1, 2024 17:05
@julioest julioest self-assigned this Aug 1, 2024
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://271.site-docs.prtest2.cppalliance.org/contributor-guide/index.html

@vinniefalco
Copy link
Member

needs squashing

Copy link
Member

@rbbeeston rbbeeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the JS code be removed now? Is there a reason to wait on it?

@vinniefalco
Copy link
Member

This needs to be broken up into individual, functional commits. For example "flatten left nav", "adjust page controls," and so on.

@julioest julioest force-pushed the update-antora-ui-template-266 branch from 012e35d to b17e460 Compare August 2, 2024 18:17
@vinniefalco
Copy link
Member

This looks very good

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://271.site-docs.prtest2.cppalliance.org/contributor-guide/index.html

Copy link
Member

@rbbeeston rbbeeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinniefalco
Copy link
Member

how does this look good to you? some controls are broken and it does not resize correctly

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://271.site-docs.prtest2.cppalliance.org/contributor-guide/index.html

@julioest
Copy link
Collaborator Author

julioest commented Aug 4, 2024

Here's a recording of the latest functionality:

issue-266-update.mp4

@julioest julioest merged commit a1a8f74 into boostorg:develop Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants