Skip to content

Commit 0d6f914

Browse files
committed
#610 update the release:prepare phase only validates the package and necessary information
1 parent f137658 commit 0d6f914

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

DRAFT_RELEASE_NOTES.md

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ _Note: instructions for adapting to these changes are outlined in the upgrade in
1616
- The `foundation-data-access` Java module
1717
- PySpark will no longer throw an exception when a required field is `None` but instead filter it out. See Changes in Spark/PySpark Schema Behavior below for more details.
1818
- Spark/PySpark will no longer filter out records with `null`/`None` fields that are not required and have validation. See Changes in Spark/PySpark Schema Behavior below for more details.
19+
- The default `preparationGoals` for the release plugin had been changed to `clean validate` to shorten the release preparation time.
1920

2021
## aiSSEMBLE-Vault Docker Image
2122
The aiSSEMBLE-vault docker image will no longer be available. We also remove the related `vault-deploy` profile.

pom.xml

+4-13
Original file line numberDiff line numberDiff line change
@@ -310,19 +310,10 @@
310310
<artifactId>maven-release-plugin</artifactId>
311311
<configuration>
312312
<scmCommentPrefix>:bookmark: [maven-release-plugin] </scmCommentPrefix>
313-
<!-- The helm charts can't be built at all once the version changes unless they are being
314-
released. Many charts depend on other charts, and so cannot be packaged properly unless those
315-
dependencies are already available in the helm repo. !!WARNING!! though it seems that we should
316-
just be using preparationProfiles, unfortunately this adds the enabled profiles to the
317-
release.properties file that the plugin uses to track settings. This file is required to run
318-
the release:perform goal, but will always allow preparationProfiles to bleed into the perform
319-
step. So if we do this naively, it ends up skipping the helm modules during release so the
320-
charts aren't published. We could add a "un-skip-helm" profile that's enabled by
321-
releaseProfiles, but that seemed worse than simply using the goals config property to bypass
322-
updating the activate profiles of release.properties.
323-
324-
Also add pyproject.toml changes to git (see below)-->
325-
<preparationGoals>clean install scm:add -Pskip-helm</preparationGoals>
313+
<!-- the CI build already compile and verify all the packages so to shorten the release:prepare time
314+
we can just validate the packages and necessary information. Also, this can also prevent the
315+
docker builder being created in the release prepare time -->
316+
<preparationGoals>clean validate</preparationGoals>
326317

327318
<!-- Because the release plugin doesn't build after updating to the next development snapshot,
328319
the habushu-managed updates to pyproject.toml files lags behind. To prevent the first

0 commit comments

Comments
 (0)