-
Notifications
You must be signed in to change notification settings - Fork 0
Add common and harness specific configuration for deployment and publication #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, @Julian. Could you please take a look at the changes in the CI workflow? |
Hi, @Julian! I hope you're doing well. Could you please advise if you have a chance to look at workflows this week or next week? If you don't have time for this at the moment, I could probably take a look at changes in how bowtie collects known implementations - use GitHub packages API along with traversing the implementations directory. It should be easy to switch to packages API only in the future once all test harnesses are moved out of the main repo. |
I think this lgtm at this point! |
Thank you, @Julian for finding time to review changes! I think the next step would be merging the changes, moving all to main branch and publishing the first image from that repository (I am not sure if this repo has rights to publish to org packages though - could you please check that @Julian ? I definitely saw an error in one of the runs when it attempted to publish an image) |
We need to make changes in the Bowtie repo from your other PR before we can delete it there right? (e.g. to ensure the doc implementation number is correct, and to ensure that the CLI has the correct full list of implementations by combining the two locations) But merging certainly sounds good to me -- remind me again (sorry) what's the step going to be to publish an image from this repo? It will happen automatically when we merge? And then automatically going forward when dependabot sends PRs? I've just added this repo to the permissions for the package (here) Thanks again for all your work!! |
Yes, you are right. The corresponding changes are done in this PR bowtie-json-schema/bowtie#1867. I tested them locally, and all looked good. But we could add a step in bowtie CI to check the number of implementations collected (until we move all implementations out). What do you think about that @Julian ?
(all is good 😄 ) No, it will not happen automatically after we merge this PR. The workflow publishes the image only if a commit is pushed into the
When this PR is merged into the |
This seems very reasonable! Perhaps as a greater-than-or-equal to check (i.e. that we have at least the current number, on the off chance we add some implementations while we're going through this move). Ahhhh I didn't notice this was |
No description provided.