Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DisallowedModelAdminLookup in SignalInfoModelAdmin, too. #140

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

jedie
Copy link
Collaborator

@jedie jedie commented Jan 26, 2024

Reported here:
#135 (comment)

Fix some code style errors in changed files, too ;)

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.95%. Comparing base (fa4c3f3) to head (39d87b8).
Report is 6 commits behind head on main.

Files Patch % Lines
huey_monitor/admin.py 73.68% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   67.79%   67.95%   +0.16%     
==========================================
  Files          36       36              
  Lines         739      749      +10     
  Branches       88       88              
==========================================
+ Hits          501      509       +8     
- Misses        238      240       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cnschn cnschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnschn cnschn merged commit 2d37f25 into main Jan 26, 2024
9 checks passed
@cnschn cnschn deleted the fix#135 branch January 26, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants