Specify revoke token return type and test for failure

Author: bpedroza

package-lock.json

@@ -113,7 +113,7 @@ export default class PKCE {
     }).then((response) => response.json());
   }
 
-  public revokeToken(tokenToExpire: string, hint: string = '') {
+  public revokeToken(tokenToExpire: string, hint: string = ''): Promise<boolean> {
     this.checkEndpoint('revoke_endpoint');
     const params = new URLSearchParams({
       token: tokenToExpire,
@@ -128,7 +128,8 @@ export default class PKCE {
       headers: {
         'Content-Type': 'application/x-www-form-urlencoded;charset=UTF-8',
       },
-    }).then((response) => response.json());
+    }).then((response) => response.ok)
+    .catch(() => false);
   }
 
   private checkEndpoint(propertyName: string) {

src/PKCE.ts

@@ -216,12 +216,26 @@ describe('Test PCKE revoke token', () => {
 
   it('Should make a request to revoke token endpoint', async () => {
     const url = 'https://example.com/revoke';
-    await mockRequest({revoke_endpoint: url});
+    const ok = await mockRequest({revoke_endpoint: url});
 
+    expect(ok).toEqual(true);
     expect(fetch.mock.calls.length).toEqual(1);
     expect(fetch.mock.calls[0][0]).toEqual(url);
   });
 
+  it('Should return false on error response', async () => {
+    const instance = new PKCE({
+      ...config,
+      revoke_endpoint: 'https://example.com/revoke'
+    });
+
+    fetch.resetMocks();
+    fetch.mockReject(new Error('fake error message'))
+    const ok = await instance.revokeToken('atoken');
+
+    expect(ok).toEqual(false);
+  });
+
   it('Should request with headers', async () => {
     const url = 'https://example.com/revoke';
     await mockRequest({revoke_endpoint: url});