Skip to content

feat(vm): add support for virtiofs #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

feat(vm): add support for virtiofs #1900

merged 2 commits into from
Apr 15, 2025

Conversation

felinira
Copy link
Contributor

@felinira felinira commented Apr 12, 2025

This adds virtiofs support for virtual machines.

Usage:

resource "proxmox_virtual_environment_vm" "test_vm1" {
    /* ... */

    virtiofs {
	    dir_id = "test"
	    cache = "always"
	    direct_io = true
	    expose_acl = false
	    expose_xattr = false
    }
}

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

image
image

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #1892 - directory mapping creation not yet implemented
Relates #1902 - acceptance test is commented out and requires #1902 as well

Copy link
Owner

@bpg bpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @felinira 👋🏼
Thank you so much for adding this feature (and upcoming #1902 😉)

I have a few minor comments, but overall it looks great, solid work!

Signed-off-by: Fina Wilke <code@felinira.net>
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 15, 2025
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Copy link
Owner

@bpg bpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@bpg bpg changed the title feat(vm): Implement virtiofs feat(vm): add support for virtiofs Apr 15, 2025
@bpg bpg merged commit 55b3f73 into bpg:main Apr 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants