Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lxc): add missing onboot param on container clone create #838

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

rafsaf
Copy link
Contributor

@rafsaf rafsaf commented Dec 26, 2023

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated templates in /example for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #794

Signed-off-by: Rafał Safin <rafal.safin@rafsaf.pl>
@bpg
Copy link
Owner

bpg commented Dec 26, 2023

It looks like PVE does not have start attribute in the update request, see PUT method in the API doc. When running examples I'm getting:

│ Error: error updating container: received an HTTP 400 response - Reason: Parameter verification failed. (start: property is not defined in schema and the schema does not allow additional properties)
│ 
│   with proxmox_virtual_environment_container.example,
│   on resource_virtual_environment_container.tf line 59, in resource "proxmox_virtual_environment_container" "example":
│   59: resource "proxmox_virtual_environment_container" "example" {
│ 

Apparently the UpdateRequestBody type definition is wrong, "start on boot" for update request is called onboot 🤦🏼

@rafsaf
Copy link
Contributor Author

rafsaf commented Dec 26, 2023

I looked at the API for a moment and didn't check it as I was pretty sure this is correct, I will try to fix it with proper testing later

Signed-off-by: Rafał Safin <rafal.safin@rafsaf.pl>
@rafsaf
Copy link
Contributor Author

rafsaf commented Dec 27, 2023

ok, onboot was correct there but start was unnecessary there

now ok

image

@rafsaf rafsaf changed the title fix(lxc): add missing start params on container clone create fix(lxc): add missing onboot param on container clone create Dec 27, 2023
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Copy link
Owner

@bpg bpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @rafsaf!

LGTM! 🚀

@bpg bpg merged commit 40102a6 into bpg:main Dec 28, 2023
7 checks passed
@ghost ghost mentioned this pull request Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

start_on_boot not applied on CT
2 participants