Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm,lxc): accept IPv6 in initialization.dns.servers attribute #842

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

LEI
Copy link
Contributor

@LEI LEI commented Dec 28, 2023

While trying to setup both IPv4 and IPv6 addresses in a VM, a validation error prevents adding IPv6 DNS in Cloud-Init initialization:

Error: expected initialization.0.dns.0.servers.1 to contain a valid IPv4 address, got: x:x:x:x:x:x

Proxmox seems to accept both there, I have yet to get IPv6 connectivity working though.

make example fails due to an SSH connection error with my setup, but I guess only IPv4 is tested anyway.

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated templates in /example for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

image

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Signed-off-by: Guillaume <4112243+LEI@users.noreply.github.com>
Copy link
Owner

@bpg bpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for the fix @LEI

LGTM! 🚀

@bpg bpg changed the title fix(dns): accept ipv6 in initialization fix(vm,lxc): accept IPv6 in initialization.dns.servers attribute Dec 28, 2023
@bpg bpg merged commit bf5cbd9 into bpg:main Dec 28, 2023
7 checks passed
@ghost ghost mentioned this pull request Dec 28, 2023
@bpg
Copy link
Owner

bpg commented Dec 28, 2023

@all-contributors please add @LEI for code

Copy link
Contributor

@bpg

I've put up a pull request to add @LEI! 🎉

@LEI LEI deleted the dns-ipv6 branch December 28, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants