Add BPMN MIWG 2023 demo results to reference #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference/C.9.1.png
Outdated
There was a problem hiding this comment.
This model has a lane that goes over the pool header. This should be corrected.
Reference/C.9.2.bpmn
Outdated
| <callActivity name="Document Request" | ||
| id="_1c9f4f0d-d193-4643-8201-0843a9a937fe" | ||
| isForCompensation="false" | ||
| calledElement="process_1c9f4f0d-d193-4643-8201-0843a9a937fe" |
There was a problem hiding this comment.
The called element here is not defined or imported, there is no way to know if the + marker should be displayed in the diagram.
There was a problem hiding this comment.
This notion is still valid in the reference models. I will add an import to fix it.
There was a problem hiding this comment.
I've added the imports via 5252a24
|
@barmac to use the reference models instead |
|
I've updated the test cases to use the reference models, and added the entries in the JSON. |
|
Make sense to me, we should merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the 2023 demo results to the Reference directory. The models used are from the live demo folder, and the renderings were produced with bpmn-to-image, equivalent to Camunda Desktop Modeler rendering.