-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Networking improvements #31
Conversation
…ead of just messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I like the direction of networking changes. It looks better than before. 👍 I left a few comments
Please next time try to do smaller PRs. 🥺 What really is in scope of “Networking improvements” could be as well split into few smaller PRs to be reviewed and merged in steps. Additionally, there are some things that are not related to “Networking improvements” that could be done in a separate PR.
Yeah, sorry for that, It was partially based on another thing which I had to prove in a broader context. Aaand it got a little bit out of hand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 All issues resolved or extracted to a separate topics
Description
This partially resolves #30 . From the requirements list this pr is missing caching. Outside requirements, but still related it's missing RemoteData improvements.
I also resolved some of issues that I discovered on the go and blocked me from moving forward.
Changes
Considerations
RehydrateAction
type is not 100% accurate, it assumes that we persist reducers only at the top levelDemo
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-06-14.at.22.21.24.mp4