Add dashboard definitions md5 to deployment annotations

[shouichi]

By annotation dashboard definitions md5, changing dashboard definitions triggers redeployment.

Close #106.

[brancz]

Nice! I wonder whether this will have a performance impact, but let's try and see! :)

[adinhodovic]

Nice! I wonder whether this will have a performance impact, but let's try and see! :)

Hey @brancz,

The behavior introduced in this PR is a bit annoying, I see that you've said that Grafana has built-in functionality for reloading on underlying dashboard configmap changes: #55 (comment). Is this really necessary then(to generate a hash for dashboards and force a redeploy)? I find the sidecar more smooth in that case. Just switched from the helm chart. Am I missing something?

[brancz]

@adinhodovic I haven't tried the hot-reloading in a while. Could you confirm that that does indeed work? If so then I agree we should make this opt-in rather than opt-out.

[adinhodovic]

@adinhodovic I haven't tried the hot-reloading in a while. Could you confirm that that does indeed work? If so then I agree we should make this opt-in rather than opt-out.

Works fine for me. Takes a minute but works. Would be great to have it configurable.

[brancz]

I would agree that this should be opt-in rather than opt-out then. Would you like to submit a PR to do that?

[adinhodovic]

Something along these lines #108?

[brancz]

Yes perfect! Merged! Thank you so much!