Customizable basename for created resources #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redbaron
force-pushed
the
customizable-name
branch
from
2e5e3d5 to
66d8387
Compare
It seems that shape of the object produced by individual
jsonnet library agreed to be following:
```
{
hidden:: { ... }
component: {
resource1: { apiVersion: ... , kind: .... },
resource2: { apiVersion: ... , kind: .... },
}
}
```
so that std.objectFields(obj) returns an object
made of kubernetes object to apply.
Hidden fields are then can be used for cooperation
on values, such as `_config::`
This commit brings produced output in line with convention above
redbaron
force-pushed
the
customizable-name
branch
3 times, most recently
from
202e4b3 to
b907c6e
Compare
If there is no dashboards, then no /grafana-dashboard-definitions/0/ is created and Grafana becomes upset, because it's provisioning config points there.
With this change it is possible to install multiple Grafanas into same namespace without clashing
redbaron
force-pushed
the
customizable-name
branch
from
b907c6e to
1c12c74
Compare
|
I generally like this a lot. Let's first get #67 resolved, then continue with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change it is possible to install multiple
Grafanas into same namespace without clashing
Also DRY object references a bit
Based on #67