Deprecate old patterns for component installers #40545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

bridiver opened this issue Aug 19, 2024 · 0 comments · Fixed by brave/brave-core#25206

Labels

OS/Desktop QA/No release-notes/exclude

Milestone

1.71.x - Release

Contributor

bridiver commented Aug 19, 2024 •

edited

Loading

We should no longer use BraveComponent or LocalDataFilesService/LocalDataFilesObserver. Each component should have it's own installer/component and follow the patterns established in upstream ex https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/component_updater/first_party_sets_component_installer.cc with the use of a singleton to manage the actual data loaded see content::FirstPartySetsHandler::GetInstance() and registration in component::RegisterComponentsForUpdate

The text was updated successfully, but these errors were encountered:

bridiver mentioned this issue

Deprecate old patterns for component installers brave/brave-core#25206

Merged

24 tasks

bridiver added QA/No release-notes/exclude OS/Desktop labels

bridiver closed this as completed in brave/brave-core#25206

brave-builds added this to the 1.71.x - Nightly milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment