Skip to content

Remove WKWebView references throughout the codebase #44707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kylehickinson opened this issue Mar 17, 2025 · 2 comments · Fixed by brave/brave-core#28158
Closed

Remove WKWebView references throughout the codebase #44707

kylehickinson opened this issue Mar 17, 2025 · 2 comments · Fixed by brave/brave-core#28158
Assignees
@kylehickinson
Labels
OS/iOS Fixes related to iOS browser functionality QA Pass - iPad QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.78.x - Release

Comments

@kylehickinson
Copy link
Collaborator

As part of the continued effort to implement Chromium web views we need to proxy away all of our direct accesses to WKWebView and its related properties via the Tab.webView property so that we can replace the underlying source of truth with Chromium's when the feature flag is enabled
@kylehickinson kylehickinson added OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude labels Mar 17, 2025
@kylehickinson kylehickinson self-assigned this Mar 17, 2025
@kylehickinson kylehickinson mentioned this issue Mar 17, 2025
Merged
24 tasks
@brave-builds brave-builds added this to the 1.78.x - Nightly milestone Mar 17, 2025
@kylehickinson kylehickinson mentioned this issue Mar 24, 2025
Closed
5 tasks
@kjozwiak
Copy link
Member

QA will run through the following two cases/verifications as per brave/brave-core#28158 (comment):

* Verify opening child tabs (e.g. Google SSO, target=_blank links) works as normal
* Verify Playlist streaming/offline downloads work

However, the following STR/Cases will get verified by default when QA starts running through 1.78.x and can be skipped for this particular issue:

* Sanity test basic web browsing & adblock
* Sanity test tab restoration

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 5, 2025
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 & iPad running iOS 18.3.1 using version 1.78.94

  • ensured that opening child tabs/google SSO works as normal
  • ensured Playlist streaming is working
  • ensured offline downloads are working
example example example example example
Image Image Image Image Image
Image Image Image Image Image

@Uni-verse Uni-verse added QA Pass - iPhone QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylehickinson kylehickinson

Labels
OS/iOS Fixes related to iOS browser functionality QA Pass - iPad QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.78.x - Release
Development

Successfully merging a pull request may close this issue.

[iOS] Remove Tab.webView usages brave/brave-core
4 participants
@kylehickinson @kjozwiak @Uni-verse @brave-builds