Skip to content

🚀 Add infra mode to satisfy CI keep-alive requirements #44727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cdesouza-chromium opened this issue Mar 17, 2025 · 0 comments · Fixed by brave/brave-core#28160
Closed

🚀 Add infra mode to satisfy CI keep-alive requirements #44727

cdesouza-chromium opened this issue Mar 17, 2025 · 0 comments · Fixed by brave/brave-core#28160

Comments

@cdesouza-chromium
Copy link
Contributor

CI needs some regular terminal output to keep alive, and because of that Brockit is being terminated when doing npm run init.

@cdesouza-chromium cdesouza-chromium self-assigned this Mar 17, 2025
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Mar 17, 2025
This PR introduces several data classes to better compartimentalise the
data being used in this tool. The previous code relied on a very large
method to do all the operations necessary during patch resolution.

The management of the continuation file is also being overhauled to be
its own code, separate from `PatchFailureResolver`, as the continuation
file also stores things like `working_version` which is not necessarily
part of the merge process.

**Version Type**

This type is being introduced to simplify the operations around version
in Brockit. The code is now easier to understand, and the operations are
grouped.

**Infra Mode**
This new execution mode suppresses the status page, and as a
replacement, provides terminal "keep alive" output, to allow the CI to
be kept alive.

Resolves brave/brave-browser#44690
Resolves brave/brave-browser#44727
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Mar 17, 2025
This PR introduces several data classes to better compartimentalise the
data being used in this tool. The previous code relied on a very large
method to do all the operations necessary during patch resolution.

The management of the continuation file is also being overhauled to be
its own code, separate from `PatchFailureResolver`, as the continuation
file also stores things like `working_version` which is not necessarily
part of the merge process.

**Version Type**

This type is being introduced to simplify the operations around version
in Brockit. The code is now easier to understand, and the operations are
grouped.

**Infra Mode**
This new execution mode suppresses the status page, and as a
replacement, provides terminal "keep alive" output, to allow the CI to
be kept alive.

Resolves brave/brave-browser#44690
Resolves brave/brave-browser#44727
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Mar 17, 2025
This PR introduces several data classes to better compartimentalise the
data being used in this tool. The previous code relied on a very large
method to do all the operations necessary during patch resolution.

The management of the continuation file is also being overhauled to be
its own code, separate from `PatchFailureResolver`, as the continuation
file also stores things like `working_version` which is not necessarily
part of the merge process.

**Version Type**

This type is being introduced to simplify the operations around version
in Brockit. The code is now easier to understand, and the operations are
grouped.

**Infra Mode**
This new execution mode suppresses the status page, and as a
replacement, provides terminal "keep alive" output, to allow the CI to
be kept alive.

Resolves brave/brave-browser#44690
Resolves brave/brave-browser#44727
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Mar 18, 2025
This PR introduces several data classes to better compartimentalise the
data being used in this tool. The previous code relied on a very large
method to do all the operations necessary during patch resolution.

The management of the continuation file is also being overhauled to be
its own code, separate from `PatchFailureResolver`, as the continuation
file also stores things like `working_version` which is not necessarily
part of the merge process.

**Version Type**

This type is being introduced to simplify the operations around version
in Brockit. The code is now easier to understand, and the operations are
grouped.

**Infra Mode**
This new execution mode suppresses the status page, and as a
replacement, provides terminal "keep alive" output, to allow the CI to
be kept alive.

Resolves brave/brave-browser#44690
Resolves brave/brave-browser#44727
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Mar 18, 2025
This PR introduces several data classes to better compartimentalise the
data being used in this tool. The previous code relied on a very large
method to do all the operations necessary during patch resolution.

The management of the continuation file is also being overhauled to be
its own code, separate from `PatchFailureResolver`, as the continuation
file also stores things like `working_version` which is not necessarily
part of the merge process.

**Version Type**

This type is being introduced to simplify the operations around version
in Brockit. The code is now easier to understand, and the operations are
grouped.

**Infra Mode**
This new execution mode suppresses the status page, and as a
replacement, provides terminal "keep alive" output, to allow the CI to
be kept alive.

Resolves brave/brave-browser#44690
Resolves brave/brave-browser#44727
@brave-builds brave-builds added this to the 1.78.x - Nightly milestone Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment