Skip to content

[Follow up to #43812] Reset button removes all custom rules created via Block element and Manual addition #44761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 6 tasks
hffvld opened this issue Mar 18, 2025 · 1 comment
Assignees
Labels
bug feature/shields/adblock/block-elements Issues related to Block Elements feature OS/Android Fixes related to Android browser functionality QA/Yes

Comments

@hffvld
Copy link
Contributor

hffvld commented Mar 18, 2025

Description

Follow-up to #43812

Steps to reproduce

  1. Launch Brave
  2. Go to https://wikipedia.org
  3. Brave Shields > Block element
  4. Select any HTML element on the page > Block Element
  5. Hamburger menu > Settings > Brave Shields & privacy > Content Filtering
  6. Create custom filters > Verify that the HTML element is added to the filter list
  7. Add a custom rule using any procedural cosmetic filter or scriplet, for example:
en.m.wikipedia.org###mp-tfa-h2:style(background-color: red !important; color: yellow !important)
  1. Close the settings > Refresh the page > Verify that both rules are applied
  2. Brave Shields > Block element
  3. Tap the Reset button > Observe that both rules are removed
  4. Hamburger menu > Settings > Brave Shields & privacy > Content Filtering
  5. Create custom filters > Observe that both rules are removed

Actual result

The Reset button removes all custom rules created via Block element and Manual addition.


1
Screencast
1

Expected result

The Reset button must remove ONLY custom rules created via the Block element feature.

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.77.82
Chromium: 134.0.6998.95 (Official Build) beta (64-bit)

Device

  • Brand/model: Pixel 7
  • Android version: 16

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@hffvld
Copy link
Contributor Author

hffvld commented Mar 19, 2025

Closing above because the custom filter wasn't properly created using a procedural cosmetic filter or scriptlets. After creating procedural cosmetic filter everything works as expected.


1
Screencast
1

@hffvld hffvld closed this as completed Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields/adblock/block-elements Issues related to Block Elements feature OS/Android Fixes related to Android browser functionality QA/Yes
Projects
None yet
Development

No branches or pull requests

2 participants