Skip to content

Brave News inline ads images are not shown on 1.78.x #44762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
btlechowski opened this issue Mar 18, 2025 · 2 comments
Closed

Brave News inline ads images are not shown on 1.78.x #44762

btlechowski opened this issue Mar 18, 2025 · 2 comments
Assignees
@tmancey
Labels
feature/ads OS/Desktop QA Pass-Linux QA/Yes regression release-notes/exclude
Milestone
1.78.x - Release

Comments

@btlechowski
Copy link

btlechowski commented Mar 18, 2025 •
edited
Loading

Description

First reported by @srirambv

This is a regression introduced in 1.78.x

Steps to reproduce

  1. Clean Profile
  2. Enable Brave News
  3. Trigger a Brave News inline ad

Actual result

Brave News inline ads image is not shown

Image

Expected result

Brave News inline ads image is shown

Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.78.50 Chromium: 134.0.6998.95 (Official Build) nightly (64-bit)
Revision 0b54a1a9438bef791c636befa2877483f236b375
OS Linux

cc @aseren @tmancey @iambrianfung
@btlechowski btlechowski added this to Ads Mar 18, 2025
@github-project-automation github-project-automation bot moved this to New issues in Ads Mar 18, 2025
@tmancey tmancey self-assigned this Mar 31, 2025
@tmancey
Copy link
Contributor

tmancey commented Mar 31, 2025

Closing as resolved by @tackley. cc @iambrianfung

@tmancey tmancey closed this as completed Mar 31, 2025
@github-project-automation github-project-automation bot moved this from New issues to Done in Ads Mar 31, 2025
@btlechowski btlechowski added this to the 1.78.x - Beta milestone Mar 31, 2025
@btlechowski
Copy link
Author

Verified with

Brave 1.78.79 Chromium: 135.0.7049.84 (Official Build) beta (64-bit)
Revision 0652a32c78a9368ee4db35ca5f58e641cda324a4
OS Linux

Verified test plan from the description

Verified Brave News ads are shown on staging:

Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads OS/Desktop QA Pass-Linux QA/Yes regression release-notes/exclude
Projects
Ads
Status: Done
Milestone
1.78.x - Release
Development

No branches or pull requests
3 participants
@tmancey @LaurenWags @btlechowski