Skip to content

[ads] NTT reporting infobar notice #44766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aseren opened this issue Mar 19, 2025 · 4 comments · Fixed by brave/brave-core#28203
Closed

[ads] NTT reporting infobar notice #44766

aseren opened this issue Mar 19, 2025 · 4 comments · Fixed by brave/brave-core#28203
Assignees
@aseren
Labels
enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA Pass - Android Tab QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.79.x - Release

Comments

@aseren
Copy link

aseren commented Mar 19, 2025

No description provided.

@aseren aseren self-assigned this Mar 19, 2025
@aseren aseren added this to Ads Mar 19, 2025
@github-project-automation github-project-automation bot moved this to New issues in Ads Mar 19, 2025
@aseren aseren changed the title [ads] NTT reporting notice [ads] NTT reporting infobar notice Mar 19, 2025
@aseren aseren moved this from New issues to In progress in Ads Mar 19, 2025
@aseren aseren mentioned this issue Mar 19, 2025
Merged
24 tasks
@aseren aseren moved this from In progress to Review in Ads Mar 19, 2025
@tmancey
Copy link
Contributor

tmancey commented Apr 2, 2025

@aseren can we please make sure we sanity test and provide screenshots if both search and NTT ad info bars are shown at the same time. I am interested to see how/if they stack.

@github-project-automation github-project-automation bot moved this from Review to Done in Ads Apr 25, 2025
@brave-builds brave-builds added this to the 1.80.x - Nightly milestone Apr 25, 2025
This was referenced Apr 25, 2025
Merged
Closed
@aseren aseren added OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Apr 28, 2025
@kjozwiak
Copy link
Member

The above requires 1.79.109 or higher for 1.79.x verification 👍

@aseren aseren mentioned this issue May 26, 2025
Open
7 tasks
@btlechowski
Copy link

Verified with

Brave 1.79.112 Chromium: 137.0.7151.44 (Official Build) (64-bit)
Revision 4b874f8aedaf6f80aa52f22edf4b7bca1b86398d
OS Linux

NewTabPageAds:should_support_confirmations_for_non_rewards/false

Verified infobar is not shown when should_support_confirmations_for_non_rewards feature param is false

Image

NewTabPageAds:should_support_confirmations_for_non_rewards/true - rewards

Verified inforbar is not shown for rewards users

Image

NewTabPageAds:should_support_confirmations_for_non_rewards/true - non-rewards - search query

Verified inforbar is shown
Image

Searched

Image

Verified infobar is shown on the next NTT

Image

Verified infobar is shown on the next NTT
Image

Verified infobar is shown on the next NTT
Image

Verified infobar is shown on the next NTT

Image

Verified infobar is no longer shown

Image

NewTabPageAds:should_support_confirmations_for_non_rewards/true - non-rewards - Learn more / opt-out choices

Verified infobar is shown

Image

Clicked Learn more / opt-out choices

Image

Verified infobar is not shown on next NTT

Image

NewTabPageAds:should_support_confirmations_for_non_rewards/true - non-rewards - Close [x]

Verified inforbar is shown

Image

Clicked x

Image

Verified infobar is not shown on next NTT

Image

NewTabPageAds:should_support_confirmations_for_non_rewards/true - non-rewards - browser restart

Verified inforbar is shown 2 times

Image

Image

Verified infobar is shown 3 times after browser restart

Image

Image

Image

Verified infobar is not shown

Image

Verified infobar is not shown after browser restart

Image

@btlechowski
Copy link

Verification passed on Brave v1.79.115 on Lenovo TB-8506FS (Android 11.0)

NewTabPageAds:should_support_confirmations_for_non_rewards/false

Verified infobar is not shown when should_support_confirmations_for_non_rewards feature param is false

Image

NewTabPageAds:should_support_confirmations_for_non_rewards/true - rewards

Verified inforbar is not shown for rewards users

Image

NewTabPageAds:should_support_confirmations_for_non_rewards/true - non-rewards - search query

Verified inforbar is shown

Image

Searched

Image

Verified infobar is shown on the next NTT

Image

Verified infobar is shown on the next NTT

Image

Verified infobar is shown on the next NTT

Image

Verified infobar is shown on the next NTT

Image

Verified infobar is no longer shown

Image

NewTabPageAds:should_support_confirmations_for_non_rewards/true - non-rewards - Learn more / opt-out choices

Verified infobar is shown

Image

Clicked Learn more / opt-out choices

Image

Verified infobar is not shown on next NTT

Image

NewTabPageAds:should_support_confirmations_for_non_rewards/true - non-rewards - Close [x]

Verified inforbar is shown

Image

Clicked x

Image

Verified infobar is not shown on next NTT

Image

NewTabPageAds:should_support_confirmations_for_non_rewards/true - non-rewards - browser restart

Verified inforbar is shown 2 times

Image

Image

Verified infobar is shown 3 times after browser restart

Image
Image

Verified infobar is not shown

Image

Verified infobar is not shown after browser restart

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA Pass - Android Tab QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Status: Done
Milestone
1.79.x - Release
Development

Successfully merging a pull request may close this issue.

[ads] NTT reporting infobar notice brave/brave-core
5 participants
@tmancey @kjozwiak @btlechowski @brave-builds @aseren