Skip to content

[iOS] Defer Contact to Wallet Endpoint #44890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 of 5 tasks
jonathansampson opened this issue Mar 23, 2025 · 0 comments
Open
3 of 5 tasks

[iOS] Defer Contact to Wallet Endpoint #44890

jonathansampson opened this issue Mar 23, 2025 · 0 comments
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality

Comments

@jonathansampson
Copy link
Contributor

jonathansampson commented Mar 23, 2025

Description

On a fresh install of Brave (prior to enabling Wallet features), opening the Settings view results in at least one call (and sometimes up to 4) to ratios.wallet.brave.com.

Samples (all to http://https://ratios.wallet.brave.com/v2/relative/provider/coingecko):

  • /fil,matic,neon,btc,avax,eth,bnb,sol,0x0d8775f648430679a709e98d2b0cb6250d2887ef/usd/1d
  • /neon,avax,btc,0x0d8775f648430679a709e98d2b0cb6250d2887ef,bnb,eth,sol,fil,matic/usd/1d
  • /0x0d8775f648430679a709e98d2b0cb6250d2887ef,avax,fil,btc,sol,matic,bnb,eth,neon/usd/1d
  • /btc,bnb,eth,neon,matic,avax,fil,sol,0x0d8775f648430679a709e98d2b0cb6250d2887ef/usd/1d
  • /btc,eth,bnb,sol,0x0d8775f648430679a709e98d2b0cb6250d2887ef,avax,matic,fil,neon/usd/1d

Steps to reproduce

  1. Install/Reset Brave
  2. Open the Settings menu

Actual result

Calls to ratios.wallet.brave.com are issued.

Expected result

Ideally, no wallet-related calls should be issued unless the user has enabled the Wallet feature.

Reproduces how often

Easily reproduced

Brave version

1.76.77

Device/iOS version

iPhone 15 Pro Max, iOS 18.3.2

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

This seems to be due to initialization of CryptoStore in settings for the NetworkStore. In interim I believe we'll need to initialize NetworkStore on it's own again, but be careful to regression test against brave-ios#5848. And likely additional checks against wallet created and locked to prevent again later (keyring service isLocked returns false if wallet is not setup, triggering update).

@jonathansampson jonathansampson added the OS/iOS Fixes related to iOS browser functionality label Mar 23, 2025
@StephenHeaps StephenHeaps added the feature/web3/wallet Integrating Ethereum+ wallet support label Mar 23, 2025
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality
Projects
Status: Backlog
Development

No branches or pull requests

3 participants