You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On a fresh install of Brave (prior to enabling Wallet features), opening the Settings view results in at least one call (and sometimes up to 4) to ratios.wallet.brave.com.
Samples (all to http://https://ratios.wallet.brave.com/v2/relative/provider/coingecko):
Ideally, no wallet-related calls should be issued unless the user has enabled the Wallet feature.
Reproduces how often
Easily reproduced
Brave version
1.76.77
Device/iOS version
iPhone 15 Pro Max, iOS 18.3.2
Affected browser versions
latest AppStore
latest TestFlight
previous TestFlight
Reproducibility
with Brave Shields disabled
in the latest version of mobile Safari
Miscellaneous information
This seems to be due to initialization of CryptoStore in settings for the NetworkStore. In interim I believe we'll need to initialize NetworkStore on it's own again, but be careful to regression test against brave-ios#5848. And likely additional checks against wallet created and locked to prevent again later (keyring service isLockedreturns false if wallet is not setup, triggering update).
The text was updated successfully, but these errors were encountered:
Uh oh!
There was an error while loading. Please reload this page.
Description
On a fresh install of Brave (prior to enabling Wallet features), opening the Settings view results in at least one call (and sometimes up to 4) to
ratios.wallet.brave.com
.Samples (all to
http://https://ratios.wallet.brave.com/v2/relative/provider/coingecko
):/fil,matic,neon,btc,avax,eth,bnb,sol,0x0d8775f648430679a709e98d2b0cb6250d2887ef/usd/1d
/neon,avax,btc,0x0d8775f648430679a709e98d2b0cb6250d2887ef,bnb,eth,sol,fil,matic/usd/1d
/0x0d8775f648430679a709e98d2b0cb6250d2887ef,avax,fil,btc,sol,matic,bnb,eth,neon/usd/1d
/btc,bnb,eth,neon,matic,avax,fil,sol,0x0d8775f648430679a709e98d2b0cb6250d2887ef/usd/1d
/btc,eth,bnb,sol,0x0d8775f648430679a709e98d2b0cb6250d2887ef,avax,matic,fil,neon/usd/1d
Steps to reproduce
Actual result
Calls to
ratios.wallet.brave.com
are issued.Expected result
Ideally, no wallet-related calls should be issued unless the user has enabled the Wallet feature.
Reproduces how often
Easily reproduced
Brave version
1.76.77
Device/iOS version
iPhone 15 Pro Max, iOS 18.3.2
Affected browser versions
Reproducibility
Miscellaneous information
This seems to be due to initialization of
CryptoStore
in settings for theNetworkStore
. In interim I believe we'll need to initializeNetworkStore
on it's own again, but be careful to regression test against brave-ios#5848. And likely additional checks against wallet created and locked to prevent again later (keyring serviceisLocked
returns false if wallet is not setup, triggering update).The text was updated successfully, but these errors were encountered: