Skip to content

[ads] Fixes new tab takeover ad confirmations fail for iOS Rewards users #44925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aseren opened this issue Mar 25, 2025 · 2 comments · Fixed by brave/brave-core#28301
Closed

[ads] Fixes new tab takeover ad confirmations fail for iOS Rewards users #44925

aseren opened this issue Mar 25, 2025 · 2 comments · Fixed by brave/brave-core#28301
Assignees
@aseren
Labels
bug feature/ads OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPhone QA/Yes regression release-notes/exclude
Milestone
1.77.x - Release

Comments

@aseren
Copy link

aseren commented Mar 25, 2025 •
edited
Loading

Test case

  • Fresh browser install
  • Join Brave Rewards
  • Open tabs until NTT is shown
    EXPECTATION: View confirmation token is sent
  • Click NTT logo
    EXPECTATION: Click confirmation token is sent
@aseren aseren added dev-concern feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Mar 25, 2025
@aseren aseren added this to Ads Mar 25, 2025
@github-project-automation github-project-automation bot moved this to New issues in Ads Mar 25, 2025
@aseren aseren moved this from New issues to To Do in Ads Mar 25, 2025
@aseren aseren mentioned this issue Mar 25, 2025
Merged
@github-project-automation github-project-automation bot moved this from To Do to Done in Ads Mar 25, 2025
@brave-builds brave-builds added this to the 1.78.x - Nightly milestone Mar 25, 2025
@tmancey tmancey changed the title [ads] Transition task queue to ads service layer [ads] Fixes new tab takeover ad confirmations fail for iOS Rewards users Mar 25, 2025
@tmancey tmancey mentioned this issue Mar 25, 2025
Closed
@tmancey tmancey added p2a priority/P2 A bad problem. We might uplift this to the next planned release. and removed OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. p2a labels Mar 25, 2025
@aseren aseren added bug and removed dev-concern labels Mar 25, 2025
@aseren aseren mentioned this issue Mar 25, 2025
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.77.93 or higher for 1.77.x verification 👍

@btlechowski
Copy link

btlechowski commented Apr 4, 2025 •
edited
Loading

Verification passed on 1.77.95 on iPhone 13 Pro Max (iOS 18.3.1)

NTT confirmations

view

info	17:00:54.901309+0200	Client	[ads] Viewed new tab page ad impression with placement id 493FAC6D-442B-4AB5-87A8-5EAB5EBB53BA and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8
info	17:00:54.903038+0200	Client	[ads] Successfully saved ad history
info	17:00:54.904428+0200	Client	[ads] Successfully processed deposit for kNewTabPageAd with creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8 and kViewedImpression valued at 0
info	17:00:54.904509+0200	Client	[ads] Confirming kViewedImpression for kNewTabPageAd with transaction id 7facd7e8-e18b-4ebf-98f3-3b1f3e69aa6b and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8
info	17:00:54.915083+0200	Client	[ads] Successfully added kViewedImpression confirmation for kNewTabPageAd with transaction id 7facd7e8-e18b-4ebf-98f3-3b1f3e69aa6b and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8 to the queue
info	17:00:54.916234+0200	Client	[ads] Process kViewedImpression confirmation for kNewTabPageAd with transaction id 7facd7e8-e18b-4ebf-98f3-3b1f3e69aa6b and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8 in 0 hours, 0 minutes, 5 seconds at 17:00:59.914
info	17:00:59.917231+0200	Client	[ads] Redeem reward confirmation
info	17:00:59.917933+0200	Client	[ads] Create reward confirmation
info	17:00:59.918324+0200	Client	[ads] URL Request:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/7facd7e8-e18b-4ebf-98f3-3b1f3e69aa6b/eyJzaWduYXR1cmUiOiJaVHNPMmFqNnVhRXRNdHFHbUtPeHJXR2o1ZjJEQThRTG5FSUdXRzIrT1BNcWNwYlVjK3dGdUNNbEJ0Wm11U1ZCWlYvMmFLVENlR3hsY015MnNtOEQ5QT09IiwidCI6InFidUoweW84VGRhaDNIL21pMGVRL0g3N3pZOTVlWlVRR00wM1V0Tm1Ldys4R2FpdXFhZHlJbWV5d0RqalFLMkMyRmVYVFdyOVJJZG1aeXJRaHpva1dBPT0ifQ==
  Content: {"blindedPaymentTokens":["RvJ1TIHthq16GovXcKgOQQxhHb8W76WzTh5S1Q64Dkg="],"buildChannel":"release","catalog":[{"id":"vbHP80iyXjDEXtPXTEG9O3wQdSis1WW94pIP2Ya+OrI="}],"createdAtTimestamp":"2025-04-04T15:00:00.000Z","creativeInstanceId":"8ea7efdf-00cb-4c66-981d-31216b82b2f8","platform":"ios","publicKey":"hLaC3RQw5++hx8zaT+47CA8r8cOlAm+ygeky/ci6T1s=","rotatingHash":"Gt0AmRfLl/TeCKzzxOZhbFlP9nyQ4eW2SpTaJV8yh6s=","segment":"untargeted","studies":[],"systemTimestamp":"2025-04-04T15:00:00.000Z","transactionId":"7facd7e8-e18b-4ebf-98f3-3b1f3e69aa6b","type":"view","versionNumber":"135.0.7049.52"}
  Content Type: applica<…>
info	17:01:00.576306+0200	Client	[ads] URL Response:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/7facd7e8-e18b-4ebf-98f3-3b1f3e69aa6b/eyJzaWduYXR1cmUiOiJaVHNPMmFqNnVhRXRNdHFHbUtPeHJXR2o1ZjJEQThRTG5FSUdXRzIrT1BNcWNwYlVjK3dGdUNNbEJ0Wm11U1ZCWlYvMmFLVENlR3hsY015MnNtOEQ5QT09IiwidCI6InFidUoweW84VGRhaDNIL21pMGVRL0g3N3pZOTVlWlVRR00wM1V0Tm1Ldys4R2FpdXFhZHlJbWV5d0RqalFLMkMyRmVYVFdyOVJJZG1aeXJRaHpva1dBPT0ifQ==
  Response Status Code: 201
  Response: {"id":"7facd7e8-e18b-4ebf-98f3-3b1f3e69aa6b","payload":{},"type":"view","createdAt":"2025-04-04T15:01:00.466Z","modifiedAt":"2025-04-04T15:01:00.466Z","creativeInstanceId":"8ea7efdf-00cb-4c66-981d-31216b82b2f8"}
info	17:01:00.576406+0200	Client	[ads] Fetch payment token in 15 s
info	17:01:15.575501+0200	Client	[ads] Fetch payment token
info	17:01:15.576071+0200	Client	[ads] URL Request:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/7facd7e8-e18b-4ebf-98f3-3b1f3e69aa6b/paymentToken
  Method: kGet
info	17:01:15.830833+0200	Client	[ads] URL Response:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/7facd7e8-e18b-4ebf-98f3-3b1f3e69aa6b/paymentToken
  Response Status Code: 200
  Response: {"id":"7facd7e8-e18b-4ebf-98f3-3b1f3e69aa6b","type":"view","createdAt":"2025-04-04T15:01:00.466Z","modifiedAt":"2025-04-04T15:01:02.742Z","creativeInstanceId":"8ea7efdf-00cb-4c66-981d-31216b82b2f8","paymentToken":{"publicKey":"vlGTZ+NzScItHa2Z4YszNVzvOC11WYmiQ1zLZ84cl20=","batchProof":"kp+ruevwDkuweoYfWNbq/Wl32MAxpMth7aBTCAd3kwl4LX/A84wwnfrHWIn27TEKFdjYDSKrbSiGXgqipjI7DA==","signedTokens":["/tYzlnrmsc3LD1wpSy8dk57D/seoSE7ZCz1IdZ0zxBo="]}}
info	17:01:15.845360+0200	Client	[ads] You have 4 payment tokens which will be redeemed in 0 hours, 56 minutes, 12 seconds at 17:57:28.062
info	17:01:15.849746+0200	Client	[ads] Successfully processed kViewedImpression confirmation for kNewTabPageAd with transaction id 7facd7e8-e18b-4ebf-98f3-3b1f3e69aa6b and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8

click

info	17:01:26.611568+0200	Client	[ads] Clicked new tab page ad with placement id 493FAC6D-442B-4AB5-87A8-5EAB5EBB53BA and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8
debug	17:01:26.612515+0200	Client	Set rule lists:
<private>
info	17:01:26.613675+0200	Client	[ads] Successfully saved ad history
info	17:01:26.614850+0200	Client	[ads] Successfully processed deposit for kNewTabPageAd with creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8 and kClicked valued at 0
info	17:01:26.614877+0200	Client	[ads] Confirming kClicked for kNewTabPageAd with transaction id 01bdc5c4-90ec-4472-ba1e-552c45ac765a and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8
info	17:01:26.636001+0200	Client	[ads] Successfully added kClicked confirmation for kNewTabPageAd with transaction id 01bdc5c4-90ec-4472-ba1e-552c45ac765a and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8 to the queue
info	17:01:26.636960+0200	Client	[ads] Process kClicked confirmation for kNewTabPageAd with transaction id 01bdc5c4-90ec-4472-ba1e-552c45ac765a and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8 in 0 hours, 0 minutes, 5 seconds at 17:01:31.631
info	17:01:31.633177+0200	Client	[ads] Redeem reward confirmation
info	17:01:31.633563+0200	Client	[ads] Create reward confirmation
info	17:01:31.633785+0200	Client	[ads] URL Request:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/01bdc5c4-90ec-4472-ba1e-552c45ac765a/eyJzaWduYXR1cmUiOiJtdHEvU3h4cGtYM1NGNDJ0YnhkSWdUNkxyMmVKZmtwOU1ROHdsUHRzbHpFY1A0cjMvUmRNdDY0aFBmRnNhR2ZFbGxxbXNUUTVNYlN4eTJWMGRPSE9Edz09IiwidCI6ImZQZFBNVW85NGtnSkZYV2pRNVVGOE1xQXZJUFhiMEtjVHgzQk1jaE1xb0d4aFJ0aFJ5UmFBakxqMWUxZ25TRWV6MzNBekM3c0FiQWttM2xLdk1FUDlBPT0ifQ==
  Content: {"blindedPaymentTokens":["Et4+MoUKhv/wb4fSNC1awsj9GIPy5y/v0EwehdlwOXM="],"buildChannel":"release","catalog":[{"id":"vbHP80iyXjDEXtPXTEG9O3wQdSis1WW94pIP2Ya+OrI="}],"createdAtTimestamp":"2025-04-04T15:00:00.000Z","creativeInstanceId":"8ea7efdf-00cb-4c66-981d-31216b82b2f8","platform":"ios","publicKey":"hLaC3RQw5++hx8zaT+47CA8r8cOlAm+ygeky/ci6T1s=","rotatingHash":"Gt0AmRfLl/TeCKzzxOZhbFlP9nyQ4eW2SpTaJV8yh6s=","segment":"untargeted","studies":[],"systemTimestamp":"2025-04-04T15:00:00.000Z","transactionId":"01bdc5c4-90ec-4472-ba1e-552c45ac765a","type":"click","versionNumber":"135.0.7049.52"}
  Content Type: applic<…>
info	17:01:32.058557+0200	Client	[ads] Landed on page for https://www.bmwusa.com/?brave-creative-id=8ea7efdf-00cb-4c66-981d-31216b82b2f8&source=image2 on tab id -1376655465
info	17:01:32.062827+0200	Client	[ads] Successfully processed deposit for kNewTabPageAd with creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8 and kLanded valued at 0
info	17:01:32.062942+0200	Client	[ads] Confirming kLanded for kNewTabPageAd with transaction id 96feace7-66a9-4493-8546-952fd747a007 and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8
info	17:01:32.075587+0200	Client	[ads] Successfully added kLanded confirmation for kNewTabPageAd with transaction id 96feace7-66a9-4493-8546-952fd747a007 and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8 to the queue
info	17:01:32.417423+0200	Client	[ads] URL Response:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/01bdc5c4-90ec-4472-ba1e-552c45ac765a/eyJzaWduYXR1cmUiOiJtdHEvU3h4cGtYM1NGNDJ0YnhkSWdUNkxyMmVKZmtwOU1ROHdsUHRzbHpFY1A0cjMvUmRNdDY0aFBmRnNhR2ZFbGxxbXNUUTVNYlN4eTJWMGRPSE9Edz09IiwidCI6ImZQZFBNVW85NGtnSkZYV2pRNVVGOE1xQXZJUFhiMEtjVHgzQk1jaE1xb0d4aFJ0aFJ5UmFBakxqMWUxZ25TRWV6MzNBekM3c0FiQWttM2xLdk1FUDlBPT0ifQ==
  Response Status Code: 201
  Response: {"id":"01bdc5c4-90ec-4472-ba1e-552c45ac765a","payload":{},"type":"click","createdAt":"2025-04-04T15:01:32.321Z","modifiedAt":"2025-04-04T15:01:32.321Z","creativeInstanceId":"8ea7efdf-00cb-4c66-981d-31216b82b2f8"}
info	17:01:32.417495+0200	Client	[ads] Fetch payment token in 15 s
info	17:01:47.418713+0200	Client	[ads] Fetch payment token
info	17:01:47.418931+0200	Client	[ads] URL Request:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/01bdc5c4-90ec-4472-ba1e-552c45ac765a/paymentToken
  Method: kGet
info	17:01:47.676743+0200	Client	[ads] URL Response:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/01bdc5c4-90ec-4472-ba1e-552c45ac765a/paymentToken
  Response Status Code: 200
  Response: {"id":"01bdc5c4-90ec-4472-ba1e-552c45ac765a","type":"click","createdAt":"2025-04-04T15:01:32.321Z","modifiedAt":"2025-04-04T15:01:34.539Z","creativeInstanceId":"8ea7efdf-00cb-4c66-981d-31216b82b2f8","paymentToken":{"publicKey":"vlGTZ+NzScItHa2Z4YszNVzvOC11WYmiQ1zLZ84cl20=","batchProof":"r4XzIZo3pInpqaSgwF6eUFStdTxhb8WewKtX5oGEgQyp4E50q5sFwk6toFT9PcNUnjjOOvCAMXcVKlvb/2exBQ==","signedTokens":["CHSbxPvhftK+ulRhzP0O3XMJDeVzpHQNXQYQinVIT1k="]}}
info	17:01:47.689436+0200	Client	[ads] You have 5 payment tokens which will be redeemed in 0 hours, 55 minutes, 40 seconds at 17:57:28.062
info	17:01:47.695286+0200	Client	[ads] Successfully processed kClicked confirmation for kNewTabPageAd with transaction id 01bdc5c4-90ec-4472-ba1e-552c45ac765a and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8

landed

info	17:01:27.046031+0200	Client	[ads] Maybe land on page for https://www.bmwusa.com/?brave-creative-id=8ea7efdf-00cb-4c66-981d-31216b82b2f8&source=image2 in 5 s
info	17:01:47.699506+0200	Client	[ads] Process kLanded confirmation for kNewTabPageAd with transaction id 96feace7-66a9-4493-8546-952fd747a007 and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8 in 0 hours, 0 minutes, 5 seconds at 17:01:52.698
info	17:01:52.700018+0200	Client	[ads] Redeem reward confirmation
info	17:01:52.701286+0200	Client	[ads] Create reward confirmation
info	17:01:52.701951+0200	Client	[ads] URL Request:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/96feace7-66a9-4493-8546-952fd747a007/eyJzaWduYXR1cmUiOiJmRFMvcG9SMFZmZjI2TXlxdGdqZ2o5MEhkM2pQU2xrL0FTS3ROam1zelhxb1N6aUNvMmZzY0JHSG1hM04zaTNGT0wvLzQ2TnhKWFRZTnVIa1NoeHNoZz09IiwidCI6ImFsMmlyK203c29BTWV4YWlNV0wxQnR0RnlpbjgxUk1jYzQ4MEttUDFwWWgyd0hvZFFRMnAwZ0hWNEFaNVpGMHphTnR3ZzBRNzdtb3Z5T2lWVWpQUEt3PT0ifQ==
  Content: {"blindedPaymentTokens":["jO8yK6wz1LX/+Xf6qp12yGLNedZxRYF5HiX+FSsZlA0="],"buildChannel":"release","catalog":[{"id":"vbHP80iyXjDEXtPXTEG9O3wQdSis1WW94pIP2Ya+OrI="}],"createdAtTimestamp":"2025-04-04T15:00:00.000Z","creativeInstanceId":"8ea7efdf-00cb-4c66-981d-31216b82b2f8","httpResponseStatus":"2xx","platform":"ios","publicKey":"hLaC3RQw5++hx8zaT+47CA8r8cOlAm+ygeky/ci6T1s=","rotatingHash":"Gt0AmRfLl/TeCKzzxOZhbFlP9nyQ4eW2SpTaJV8yh6s=","segment":"untargeted","studies":[],"systemTimestamp":"2025-04-04T15:00:00.000Z","transactionId":"96feace7-66a9-4493-8546-952fd747a007","type":"landed","versionNumber":"135.0.7049<…>
info	17:01:53.002805+0200	Client	[ads] URL Response:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/96feace7-66a9-4493-8546-952fd747a007/eyJzaWduYXR1cmUiOiJmRFMvcG9SMFZmZjI2TXlxdGdqZ2o5MEhkM2pQU2xrL0FTS3ROam1zelhxb1N6aUNvMmZzY0JHSG1hM04zaTNGT0wvLzQ2TnhKWFRZTnVIa1NoeHNoZz09IiwidCI6ImFsMmlyK203c29BTWV4YWlNV0wxQnR0RnlpbjgxUk1jYzQ4MEttUDFwWWgyd0hvZFFRMnAwZ0hWNEFaNVpGMHphTnR3ZzBRNzdtb3Z5T2lWVWpQUEt3PT0ifQ==
  Response Status Code: 201
  Response: {"id":"96feace7-66a9-4493-8546-952fd747a007","payload":{},"type":"landed","createdAt":"2025-04-04T15:01:52.881Z","modifiedAt":"2025-04-04T15:01:52.881Z","creativeInstanceId":"8ea7efdf-00cb-4c66-981d-31216b82b2f8"}
info	17:01:53.003066+0200	Client	[ads] Fetch payment token in 15 s
info	17:02:08.004492+0200	Client	[ads] Fetch payment token
info	17:02:08.005013+0200	Client	[ads] URL Request:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/96feace7-66a9-4493-8546-952fd747a007/paymentToken
  Method: kGet
info	17:02:08.262187+0200	Client	[ads] URL Response:
  URL: https://anonymous.ads.bravesoftware.com/v3/confirmation/96feace7-66a9-4493-8546-952fd747a007/paymentToken
  Response Status Code: 200
  Response: {"id":"96feace7-66a9-4493-8546-952fd747a007","type":"landed","createdAt":"2025-04-04T15:01:52.881Z","modifiedAt":"2025-04-04T15:01:54.921Z","creativeInstanceId":"8ea7efdf-00cb-4c66-981d-31216b82b2f8","paymentToken":{"publicKey":"vlGTZ+NzScItHa2Z4YszNVzvOC11WYmiQ1zLZ84cl20=","batchProof":"huTGA9wFjVTTfpvl7Utes23T5hNh7opWNnZ/Dig6SA+6BSN0ek4eBFEYJH0andi42686sTueWO2owWVvaiCkCw==","signedTokens":["Kivw/dB7lYnlBCf53PYaxfTQcHLe8HvqGARfTNCW9Qg="]}}
info	17:02:08.279100+0200	Client	[ads] You have 6 payment tokens which will be redeemed in 0 hours, 55 minutes, 20 seconds at 17:57:28.062
info	17:02:08.283165+0200	Client	[ads] Successfully processed kLanded confirmation for kNewTabPageAd with transaction id 96feace7-66a9-4493-8546-952fd747a007 and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
bug feature/ads OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPhone QA/Yes regression release-notes/exclude
Projects
Ads
Status: Done
Milestone
1.77.x - Release
Development

Successfully merging a pull request may close this issue.

[ads] Fixes new tab takeover ad confirmations fail for iOS Rewards users brave/brave-core
5 participants
@tmancey @kjozwiak @btlechowski @brave-builds @aseren