Skip to content

Upgrade from Chromium 136 to Chromium 137 #45154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cdesouza-chromium opened this issue Apr 2, 2025 · 6 comments · Fixed by brave/brave-core#28471
Closed

Upgrade from Chromium 136 to Chromium 137 #45154

cdesouza-chromium opened this issue Apr 2, 2025 · 6 comments · Fixed by brave/brave-core#28471

Comments

@cdesouza-chromium
Copy link
Contributor

cdesouza-chromium commented Apr 2, 2025

Description

Upgrade from Chromium 136 to Chromium 137

https://chromium.googlesource.com/chromium/src/+log/136.0.7103.93..137.0.7151.16?pretty=fuller&n=10000

QA tests

This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

  • AI Chat extraction from PDF
  • Components get downloaded/updated
  • Search Engines:
    • correct engines for different countries (check a few countries where we have different defaults)
    • install an old version (v1.28.80), upgrade to the current version and change the default engine to something else. Reset settings and check that the default engine got reset back to the default engine in 1.28.80 (Google). cc: @bsclifton to confirm.
  • Location permissions dialog looks correctly
  • Avatar menu looks correctly
  • Bookmarks sidebar works correctly (shows up / hides)
  • Hamburger menu icons look correctly
  • brave://flags loads

iOS Affected areas:

  • Sync works

Android Affected areas:

  • Location permissions dialog looks correctly
  • Bottom navigation controls (since edge to edge bottom chin is enabled, we need to double check they work as expected in all modes: browsing and tab switching)
  • Tab groups bottom strip with bottom navigation controls enabled (double check it is shown as expected)
  • Main menu (double check there are proper isons and functions as expected)
  • Brave Password Manager (double check works as expected, including sync and export passwords)
  • Double check toolbar buttons work as expected (both top and bottom toolbar)
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 14, 2025

Verification PASSED on

Brave | 1.80.62 Chromium: 137.0.7151.16 (Official Build) nightly (64-bit)
-- | --
Revision | 9e40e948a08ef35ac066f537d4b89a5c7ae9040b
OS | Windows 10 Version 22H2 (Build 19045.5796)
Components get downloaded/updated_PASSED
  • Confirmed that components are loaded on startup
  • Confirmed that components are updated successfully without any error
  • Confirmed that Tor components is updated without any error
  • Confirmed that Widevine component is updated without any error
Example Example Example
Image Image Image
Search Engines_PASSED
Case 1: India_Clean profile default SE_PASSED
  • Confirmed that the Brave is the default SE via brave://settings/search/defaultSearch
  • Confirmed that the Brave is the default SE via brave://settings/search/privateSearch
  • Confirmed that Brave displayed at the top in the dropdown list
1.80.x 1.80.x 1.80.x 1.80.x
Image Image Image Image
Case 2: India_Don't change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED

Confirmed Brave is shown on the top and selected as a default in brave://settings/search/defaultSearch and brave://settings/search/privateSearch

1.78.x 1.78.x 1.78.x 1.78.x
Image Image Image Image
1.80.x 1.80.x 1.80.x 1.80.x
Image Image Image Image
Case 3: India_Change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED
  • Change the default SE to Google via brave://settings/search/defaultSearch
  • Change the default SE to Startpage via brave://settings/search/privateSearch
1.78.x 1.78.x 1.78.x 1.78.x
Image Image Image Image
  • Confirmed that the default SE Google retained upon upgrade via brave://settings/search/defaultSearch
  • Confirmed that the default SE to Startpage retained upon upgrade via brave://settings/search/privateSearch
  • Confirmed Brave is shown on the top of the dropdown list
1.80.x 1.80.x 1.80.x 1.80.x
Image Image Image Image
Case 1: Japan_Clean profile default SE_PASSED
  • Confirmed that the Yahoo! JAPAN is the default SE via brave://settings/search/defaultSearch
  • Confirmed that the Brave is the default SE via brave://settings/search/privateSearch
  • Confirmed that Yahoo! JAPAN is selected and displayed at the top in the dropdown list via brave://settings/search/defaultSearch
  • Confirmed that Yahoo! JAPAN is NOT selected and displayed at the top in the dropdown list via brave://settings/search/privateSearch
1.80.x 1.80.x 1.80.x 1.80.x
Image Image Image Image
Case 2: Japan_Don't change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED
  • Confirmed that the Yahoo! JAPAN is the default SE via brave://settings/search/defaultSearch
    upon upgrade to 1.80.x
  • Confirmed that the Brave is the default SE via brave://settings/search/privateSearch
    upon upgrade to 1.80.x
1.78.x 1.78.x 1.78.x 1.78.x
Image Image Image Image
1.80.x 1.80.x 1.80.x 1.80.x
Image Image Image Image
Case 3: Japan_Change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED
  • Confirmed that Yahoo! JAPAN is the default SE via brave://settings/search/defaultSearch on 1.78.x
  • Confirmed that the Brave is the default SE via brave://settings/search/privateSearch on 1.78.x
  • Change the default SE to Google via brave://settings/search/defaultSearch via 1.78
  • Change the default SE to Startpage via brave://settings/search/privateSearch via 1.78
1.78.x 1.78.x 1.78.x
Image Image Image
  • Upgraded the profile to 1.80.x
  • Confirmed that the default SE Google retained upon upgrade via brave://settings/search/defaultSearch
  • Confirmed that the default SE to Startpage retained upon upgrade via brave://settings/search/privateSearch
1.80.x 1.80.x 1.80.x 1.80.x
Image Image Image Image
Case 1: Russia_Clean profile default SE_PASSED
  • Confirmed that the Yandex is the default SE via brave://settings/search/defaultSearch
  • Confirmed that the Brave is the default SE via brave://settings/search/privateSearch
  • Confirmed that Yandex is selected and displayed at the top in the dropdown list via brave://settings/search/defaultSearch
  • Confirmed that Yandex is NOT selected and displayed at the top in the dropdown list via brave://settings/search/privateSearch
1.80.x 1.80.x 1.80.x
Image Image Image
Case 2: Russia_Don't change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED
  • Confirmed that Yandex is the default SE via brave://settings/search/defaultSearch upon upgrade to 1.80.x
  • Confirmed that the Brave is the default SE via brave://settings/search/privateSearch upon upgrade to 1.80.x
1.78.x 1.78.x 1.78.x 1.78.x
Image Image Image Image
1.80.x 1.80.x 1.80.x 1.80.x
Image Image Image Image
Case 3: Russia_Change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED
  • Confirmed that Yandex is the default SE via brave://settings/search/defaultSearch on 1.78.x
  • Confirmed that the Brave is the default SE via brave://settings/search/privateSearch on 1.78.x
  • Change the default SE to Google via brave://settings/search/defaultSearch via 1.78
  • Change the default SE to Startpage via brave://settings/search/privateSearch via 1.78
1.78.x 1.78.x 1.78.x
Image Image Image
  • Upgraded the profile to 1.80.x
  • Confirmed that the default SE Google retained upon upgrade via brave://settings/search/defaultSearch
  • Confirmed that the default SE to Startpage retained upon upgrade via brave://settings/search/privateSearch
1.80.x 1.80.x 1.80.x 1.80.x
Image Image Image Image
Case 1: Poland_Clean profile default SE_PASSED
  • Confirmed that the Google is the default SE via brave://settings/search/defaultSearch
  • Confirmed that the Brave is the default SE via brave://settings/search/privateSearch
  • Confirmed that Google is selected and is displayed at the 2nd position and Brave is displayed at top in the dropdown list via brave://settings/search/defaultSearch
  • Confirmed that Brave is selected and displayed at the top in the dropdown list via brave://settings/search/privateSearch
1.80.x 1.80.x 1.80.x
Image Image Image
Case 2: Poland_Don't change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED

Confirmed Google default SE via brave://settings/search/defaultSearch and confirmed that the Brave is the default SE via brave://settings/search/privateSearch

1.78.x 1.78.x 1.78.x 1.78.x
Image Image Image Image
1.80.x 1.80.x 1.80.x 1.80.x
Image Image Image Image
Case 3: Poland_Change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED
  • Confirmed that Google is the default SE via brave://settings/search/defaultSearch on 1.78.x
  • Confirmed that the Brave is the default SE via brave://settings/search/privateSearch on 1.78.x
  • Change the default SE to Bing via brave://settings/search/defaultSearch via 1.78
  • Change the default SE to Startpage via brave://settings/search/privateSearch via 1.78
1.78.x 1.78.x 1.78.x
Image Image Image
  • Upgraded the profile to 1.80.x
  • Confirmed that the default SE Bing retained upon upgrade via brave://settings/search/defaultSearch
  • Confirmed that the default SE to Startpage retained upon upgrade via brave://settings/search/privateSearch
1.80.x 1.80.x 1.80.x 1.80.x
Image Image Image Image
correct engines for different countries (check a few countries where we have different defaults)_PASSED
  • Verified this in the case above
  • Verified the SE for different countries like India, Russia, Japan and Poland for different default SE's Brave, Yandex, Yahoo JAPAN and Google
India_install an old version ([v1.28.80](https://github.com/brave/brave-core/releases/tag/v1.28.80)), upgrade to the current version and change the default engine to something else. Reset settings and check that the default engine got reset back to the default engine in 1.28.80 (Google)_PASSED
  • Confirmed that Google is the default SE in both Normal and Private tab windows
1.28.80 1.28.80 1.28.80
Image Image Image

Upgrade the profile to 1.80.63 -

  • Confirmed that Google is the default SE in Normal windows
  • Confirmed that Brave is the default SE in Private windows

Image

Change the default SE in both Normal (Duckduckgo) and Private window (Bing)

Image

Reset setting via brave://settings/reset

  • Confirmed that default engine got reset back to the default engine in 1.28.80 (Google)

Image

Location permissions dialog looks correctly_PASSED
  • Confirmed that the location permission dialog is shown or looks as expected when user visit https://browserleaks.com/geo
  • Confirmed that location permission dropdown items looks as expected
  • Confirmed that location is shown as expected when user select Allow permission on location permission dialog
Example Example Example
Image Image Image
  • Confirmed that the location permission dialog is shown or looks as expected when user visit https://html5demos.com/geo/
  • Confirmed that location permission dropdown items looks as expected
  • Confirmed that location is shown as expected when user select Allow permission on location permission dialog
Example Example Example
Image Image Image
Avatar menu looks correctly_PASSED
  • Confirmed that user can create a new profile via Hamburger menu->More tools->Add new profile
  • Confirmed that user can create new profiles via Profile manager->Add a new profile or + button via Manage brave profile manager
  • Confirmed that user can switch to different profile via profile picker menu
  • Confirmed that user can ADD/Edit/Delete the profiles via Profile manager
  • Confirmed that user can open the Guest window using Open Guest profile option via profile picker
  • Open few sites and update the brave://settings in Profile 1 and ensure that the change made in profile 1 aren't reflected in other profiles
  • Confirmed that avatar menu looks as expected while creating a new profile
  • Confirmed that user can select avatar while creating a new profile
  • Confirmed that selected avatar is shown when profile is created
Example Example Example Example Example
Image Image Image Image Image
Bookmarks sidebar works correctly (shows up / hides)_PASSED
  • Confirmed that imported/added bookmarks are shown under brave://bookmarks and side panel bookmarks
  • Confirmed that bookmarks folders can be re-arranged using sort by feature via side panel bookmarks
  • Confirmed that all the bookmarks under the folder can be opened in a new window/private window or in a tab group
  • Confirmed that bookmarks can be viewed in Visual view/compact view
  • Confirmed that bookmarks folders can be edited/deleted via side panel
  • Confirmed that bookmarks can be hidden/expanded using side panel bookmarks
  • Confirmed that synced bookmarks from mobile devices are shown via side panel bookmarks
  • Confirmed that bookmarks bar is shown on the Private and Private window with Tor tabs
Example Example Example Example Example
Image Image Image Image Image
Hamburger menu icons look correctly_PASSED
  • Confirmed that Hamburger menu settings are shown as expected in Normal/PT and Private window with Tor windows
  • Confirmed that icon for each Hamburger menu settings is shown as expected
Example Example Example
Image Image Image
brave://flags loads_PASSED
  • Confirmed that brave://flags opens up and expected results are shown via brave://flags

Image


Settings comparison

  • A new settings Verify it's you to autofill payment methods added as part of CR 137

Image

Brave startup calls

  • Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
  • Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

@GeetaSarvadnya
Copy link

@srirambv Can you verify Leo related item AI Chat extraction from PDF using CR 137 nightly build https://github.com/brave/brave-browser/releases/tag/v1.80.62? Thanks!

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.80.62 Chromium: 137.0.7151.16 (Official Build) nightly (64-bit)
Revision 9e40e948a08ef35ac066f537d4b89a5c7ae9040b
OS Windows 11 Version 24H2 (Build 26100.3775)
  • Verified AI summarizer works on PDF's
  • Verified AI summarizer works on image based PDF's
  • Verified AI summarizer works on PDF's with blank pages

@hffvld
Copy link
Contributor

hffvld commented May 14, 2025

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
Brave build: 1.80.62
Chromium: 137.0.7151.16 (Official Build) canary (64-bit) 

Filed follow-up issue #46081, #46082 and #46110

Location permissions dialog looks correctly

ACTUAL RESULTS:

  • Verified that the device's location dialog is shown when navigating to a website with a location access request, for example, www.maps.google.com or www.mylocation.org.
  • Verified that tap Block or Allow works as expected.
1 2 3
1 2 3
1 2 3
Bottom navigation controls (since edge-to-edge bottom chin is enabled, we need to double check they work as expected in all modes: browsing and tab switching)

ACTUAL RESULTS:

  • Verified that the Bottom navigation toolbar is unavailable on the tablet.
  • Verified that the Address bar is unavailable on the tablet if #android-bottom-toolbar flag is ON.
1 2 3 4
1 2 3 4
1 2 3 4
Tab groups bottom strip with bottom navigation controls enabled (double check it is shown as expected)

ACTUAL RESULTS:

  • Verified that the Tab group bottom strip is unavailable on the tablet if #android-bottom-toolbar flag is ON or OFF.
  • Verified that the Tab group in the top toolbar/address bar works as expected.
  • Verified that the Tab group can be created, renamed, colorized, deleted, collapsed or expanded.
1 2 3
1 2 3
1 2 3
Main menu (double check there are proper icons and functions as expected)

ACTUAL RESULTS:

  • Verified that icons in the Main menu look and function as expected.
1 2
1 2
1 2
1 2
1 2
1 2
Brave Password Manager (double check works as expected, including sync and export passwords)

ACTUAL RESULTS:

  • Verified that the new login and password can be saved to Brave without the Sync chain.
  • Verified that existing passwords are synced across devices after joining the Sync chain.
  • Verified that the saved password can be reused to sign in to a website.
  • Verified that the Export passwords works as expected.
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
Double check toolbar buttons work as expected (both top and bottom toolbar)

ACTUAL RESULTS:

  • Verified that the Bottom toolbar is not available on the Tablet.
  • Verified that the Top toolbar works as expected, including tapping all buttons/opening UI.
1 2 3
1 2 3
1 2 3

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 15, 2025
@hffvld hffvld added QA Pass - Android Tab QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA Pass-Win64 labels May 15, 2025
@hffvld
Copy link
Contributor

hffvld commented May 15, 2025

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 16 BP22.250325.012 release-keys
Brave build: 1.80.70
Chromium: 137.0.7151.16 (Official Build) canary (64-bit) 

Location permissions dialog looks correctly

ACTUAL RESULTS:

  • Verified that the device's location dialog is shown when navigating to a website with a location access request, for example, www.maps.google.com or www.mylocation.org.
  • Verified that tap Block or Allow works as expected.
1 2 3
1 2 3
1 2 3
Bottom navigation controls (since edge-to-edge bottom chin is enabled, we need to double check they work as expected in all modes: browsing and tab switching)

ACTUAL RESULTS:

  • Verified that the NTP and Tab overview UI looks and works as expected if Bottom navigation toolbar is ON or OFF.
  • Verified that the Address bar UI looks and works as expected if #android-bottom-toolbar flag is ON or OFF.
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
Tab groups bottom strip with bottom navigation controls enabled (double check it is shown as expected)

ACTUAL RESULTS:

  • Verified that the Tab group strip looks and works as expected if:
    • Addres bar is TOP + Bottom nav bar is OFF
    • Addres bar is TOP + Bottom nav bar is ON
    • Addres bar is BOTTOM + Bottom nav bar is DISABLED
  • Verified that the Tab group can be created, renamed, colorized and deleted.

Addres bar is TOP + Bottom nav bar is OFF

1 2 3
1 2 3
1 2 3

Addres bar is TOP + Bottom nav bar is ON

1 2 3 4 5 6
1 2 3 4 5 6
1 2 3 4 5 6

Addres bar is BOTTOM + Bottom nav bar is DISABLED

1 2 3 4 5 6
1 2 3 4 5 6
1 2 3 4 5 6
Main menu (double check there are proper icons and functions as expected)

ACTUAL RESULTS:

  • Verified that icons in the Main menu look and function as expected.
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
Brave Password Manager (double check works as expected, including sync and export passwords)

ACTUAL RESULTS:

  • Verified that the new login and password can be saved to Brave without the Sync chain.
  • Verified that existing passwords are synced across devices after joining the Sync chain.
  • Verified that the saved password can be reused to sign in to a website.
  • Verified that the Export passwords works as expected.
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
Double check toolbar buttons work as expected (both top and bottom toolbar)

ACTUAL RESULTS:

  • Verified that all buttons works as expected if Bottom navigation toolbar is ON or OFF.
  • Verified that all buttons works as expected if Address bar is set to TOP or BOTTOM.

Addres bar is TOP + Bottom nav bar is OFF

1 2 3 4
1 2 3 4
1 2 3 4

Addres bar is TOP + Bottom nav bar is ON

1 2 3
1 2 3
1 2 3
1 2 3

Addres bar is BOTTOM + Bottom nav bar is DISABLED

1 2 3 4
1 2 3 4
1 2 3 4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 15, 2025
@brave-builds brave-builds removed this from the 1.80.x - Nightly milestone May 16, 2025
@brave-builds brave-builds added this to the 1.79.x - Beta milestone May 16, 2025
@kjozwiak
Copy link
Member

Labelling the above as QA/No & release-notes/exclude in favour of #46111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants