-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Upgrade from Chromium 136 to Chromium 137 #45154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Verification PASSED on
Components get downloaded/updated_PASSED
Search Engines_PASSEDCase 1: India_Clean profile default SE_PASSED
Case 2: India_Don't change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSEDConfirmed Brave is shown on the top and selected as a default in
|
1.78.x | 1.78.x | 1.78.x | 1.78.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
1.80.x | 1.80.x | 1.80.x | 1.80.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Case 3: India_Change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED
- Change the default SE to
Google
viabrave://settings/search/defaultSearch
- Change the default SE to
Startpage
viabrave://settings/search/privateSearch
1.78.x | 1.78.x | 1.78.x | 1.78.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
- Confirmed that the default SE
Google
retained upon upgrade viabrave://settings/search/defaultSearch
- Confirmed that the default SE to
Startpage
retained upon upgrade viabrave://settings/search/privateSearch
- Confirmed
Brave
is shown on the top of the dropdown list
1.80.x | 1.80.x | 1.80.x | 1.80.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Case 1: Japan_Clean profile default SE_PASSED
- Confirmed that the
Yahoo! JAPAN
is the default SE viabrave://settings/search/defaultSearch
- Confirmed that the
Brave
is the default SE viabrave://settings/search/privateSearch
- Confirmed that
Yahoo! JAPAN
is selected and displayed at the top in the dropdown list viabrave://settings/search/defaultSearch
- Confirmed that
Yahoo! JAPAN
is NOT selected and displayed at the top in the dropdown list viabrave://settings/search/privateSearch
1.80.x | 1.80.x | 1.80.x | 1.80.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Case 2: Japan_Don't change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED
- Confirmed that the
Yahoo! JAPAN
is the default SE viabrave://settings/search/defaultSearch
upon upgrade to 1.80.x - Confirmed that the
Brave
is the default SE viabrave://settings/search/privateSearch
upon upgrade to 1.80.x
1.78.x | 1.78.x | 1.78.x | 1.78.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
1.80.x | 1.80.x | 1.80.x | 1.80.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Case 3: Japan_Change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED
- Confirmed that
Yahoo! JAPAN
is the default SE viabrave://settings/search/defaultSearch
on 1.78.x - Confirmed that the
Brave
is the default SE viabrave://settings/search/privateSearch
on 1.78.x - Change the default SE to
Google
viabrave://settings/search/defaultSearch
via 1.78 - Change the default SE to
Startpage
viabrave://settings/search/privateSearch
via 1.78
1.78.x | 1.78.x | 1.78.x |
---|---|---|
![]() |
![]() |
![]() |
- Upgraded the profile to 1.80.x
- Confirmed that the default SE
Google
retained upon upgrade viabrave://settings/search/defaultSearch
- Confirmed that the default SE to
Startpage
retained upon upgrade viabrave://settings/search/privateSearch
1.80.x | 1.80.x | 1.80.x | 1.80.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Case 1: Russia_Clean profile default SE_PASSED
- Confirmed that the
Yandex
is the default SE viabrave://settings/search/defaultSearch
- Confirmed that the
Brave
is the default SE viabrave://settings/search/privateSearch
- Confirmed that
Yandex
is selected and displayed at the top in the dropdown list viabrave://settings/search/defaultSearch
- Confirmed that
Yandex
is NOT selected and displayed at the top in the dropdown list viabrave://settings/search/privateSearch
1.80.x | 1.80.x | 1.80.x |
---|---|---|
![]() |
![]() |
![]() |
Case 2: Russia_Don't change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED
- Confirmed that
Yandex
is the default SE viabrave://settings/search/defaultSearch
upon upgrade to 1.80.x - Confirmed that the
Brave
is the default SE viabrave://settings/search/privateSearch
upon upgrade to 1.80.x
1.78.x | 1.78.x | 1.78.x | 1.78.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
1.80.x | 1.80.x | 1.80.x | 1.80.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Case 3: Russia_Change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED
- Confirmed that
Yandex
is the default SE viabrave://settings/search/defaultSearch
on 1.78.x - Confirmed that the
Brave
is the default SE viabrave://settings/search/privateSearch
on 1.78.x - Change the default SE to
Google
viabrave://settings/search/defaultSearch
via 1.78 - Change the default SE to
Startpage
viabrave://settings/search/privateSearch
via 1.78
1.78.x | 1.78.x | 1.78.x |
---|---|---|
![]() |
![]() |
![]() |
- Upgraded the profile to 1.80.x
- Confirmed that the default SE
Google
retained upon upgrade viabrave://settings/search/defaultSearch
- Confirmed that the default SE to
Startpage
retained upon upgrade viabrave://settings/search/privateSearch
1.80.x | 1.80.x | 1.80.x | 1.80.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Case 1: Poland_Clean profile default SE_PASSED
- Confirmed that the
Google
is the default SE viabrave://settings/search/defaultSearch
- Confirmed that the
Brave
is the default SE viabrave://settings/search/privateSearch
- Confirmed that
Google
is selected and is displayed at the 2nd position andBrave
is displayed at top in the dropdown list viabrave://settings/search/defaultSearch
- Confirmed that
Brave
is selected and displayed at the top in the dropdown list viabrave://settings/search/privateSearch
1.80.x | 1.80.x | 1.80.x |
---|---|---|
![]() |
![]() |
![]() |
Case 2: Poland_Don't change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED
Confirmed Google default SE via brave://settings/search/defaultSearch
and confirmed that the Brave
is the default SE via brave://settings/search/privateSearch
1.78.x | 1.78.x | 1.78.x | 1.78.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
1.80.x | 1.80.x | 1.80.x | 1.80.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Case 3: Poland_Change the default SE in 1.78.x and upgrade profile to 1.80.x_PASSED
- Confirmed that
Google
is the default SE viabrave://settings/search/defaultSearch
on 1.78.x - Confirmed that the
Brave
is the default SE viabrave://settings/search/privateSearch
on 1.78.x - Change the default SE to
Bing
viabrave://settings/search/defaultSearch
via 1.78 - Change the default SE to
Startpage
viabrave://settings/search/privateSearch
via 1.78
1.78.x | 1.78.x | 1.78.x |
---|---|---|
![]() |
![]() |
![]() |
- Upgraded the profile to 1.80.x
- Confirmed that the default SE
Bing
retained upon upgrade viabrave://settings/search/defaultSearch
- Confirmed that the default SE to
Startpage
retained upon upgrade viabrave://settings/search/privateSearch
1.80.x | 1.80.x | 1.80.x | 1.80.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
correct engines for different countries (check a few countries where we have different defaults)_PASSED
- Verified this in the case above
- Verified the SE for different countries like India, Russia, Japan and Poland for different default SE's Brave, Yandex, Yahoo JAPAN and Google
India_install an old version ([v1.28.80](https://github.com/brave/brave-core/releases/tag/v1.28.80)), upgrade to the current version and change the default engine to something else. Reset settings and check that the default engine got reset back to the default engine in 1.28.80 (Google)_PASSED
- Confirmed that
Google
is the default SE in both Normal and Private tab windows
1.28.80 |
1.28.80 |
1.28.80 |
---|---|---|
![]() |
![]() |
![]() |
Upgrade the profile to 1.80.63 -
- Confirmed that
Google
is the default SE in Normal windows - Confirmed that
Brave
is the default SE in Private windows
Change the default SE in both Normal (Duckduckgo) and Private window (Bing)
Reset setting via brave://settings/reset
- Confirmed that default engine got reset back to the default engine in 1.28.80 (Google)
Location permissions dialog looks correctly_PASSED
- Confirmed that the location permission dialog is shown or looks as expected when user visit https://browserleaks.com/geo
- Confirmed that location permission dropdown items looks as expected
- Confirmed that location is shown as expected when user select
Allow
permission on location permission dialog
Example | Example | Example |
---|---|---|
![]() |
![]() |
![]() |
- Confirmed that the location permission dialog is shown or looks as expected when user visit https://html5demos.com/geo/
- Confirmed that location permission dropdown items looks as expected
- Confirmed that location is shown as expected when user select
Allow
permission on location permission dialog
Example | Example | Example |
---|---|---|
![]() |
![]() |
![]() |
Avatar menu looks correctly_PASSED
- Confirmed that user can create a new profile via
Hamburger menu->More tools->Add new profile
- Confirmed that user can create new profiles via Profile manager->Add a new profile or
+
button via Manage brave profile manager - Confirmed that user can switch to different profile via profile picker menu
- Confirmed that user can
ADD/Edit/Delete
the profiles viaProfile manager
- Confirmed that user can open the Guest window using
Open Guest profile
option via profile picker - Open few sites and update the brave://settings in Profile 1 and ensure that the change made in profile 1 aren't reflected in other profiles
- Confirmed that avatar menu looks as expected while creating a new profile
- Confirmed that user can select avatar while creating a new profile
- Confirmed that selected avatar is shown when profile is created
Example | Example | Example | Example | Example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Bookmarks sidebar works correctly (shows up / hides)_PASSED
- Confirmed that imported/added bookmarks are shown under brave://bookmarks and side panel bookmarks
- Confirmed that bookmarks folders can be re-arranged using sort by feature via side panel bookmarks
- Confirmed that all the bookmarks under the folder can be opened in a new window/private window or in a tab group
- Confirmed that bookmarks can be viewed in Visual view/compact view
- Confirmed that bookmarks folders can be edited/deleted via side panel
- Confirmed that bookmarks can be hidden/expanded using side panel bookmarks
- Confirmed that synced bookmarks from mobile devices are shown via side panel bookmarks
- Confirmed that bookmarks bar is shown on the Private and Private window with Tor tabs
Example | Example | Example | Example | Example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Hamburger menu icons look correctly_PASSED
- Confirmed that Hamburger menu settings are shown as expected in Normal/PT and Private window with Tor windows
- Confirmed that icon for each Hamburger menu settings is shown as expected
Example | Example | Example |
---|---|---|
![]() |
![]() |
![]() |
brave://flags loads_PASSED
- Confirmed that brave://flags opens up and expected results are shown via brave://flags
Settings comparison
Brave startup calls
- Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
- Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile
@srirambv Can you verify Leo related item |
Verification passed on
|
Verified on
Filed follow-up issue #46081, #46082 and #46110Location permissions dialog looks correctlyACTUAL RESULTS:
Bottom navigation controls (since edge-to-edge bottom chin is enabled, we need to double check they work as expected in all modes: browsing and tab switching)ACTUAL RESULTS:
Tab groups bottom strip with bottom navigation controls enabled (double check it is shown as expected)ACTUAL RESULTS:
Main menu (double check there are proper icons and functions as expected)ACTUAL RESULTS:
Brave Password Manager (double check works as expected, including sync and export passwords)ACTUAL RESULTS:
|
Verified on
Location permissions dialog looks correctlyACTUAL RESULTS:
Bottom navigation controls (since edge-to-edge bottom chin is enabled, we need to double check they work as expected in all modes: browsing and tab switching)ACTUAL RESULTS:
Tab groups bottom strip with bottom navigation controls enabled (double check it is shown as expected)ACTUAL RESULTS:
Main menu (double check there are proper icons and functions as expected)ACTUAL RESULTS:
Brave Password Manager (double check works as expected, including sync and export passwords)ACTUAL RESULTS:
Double check toolbar buttons work as expected (both top and bottom toolbar)ACTUAL RESULTS:
|
Labelling the above as |
Uh oh!
There was an error while loading. Please reload this page.
Description
Upgrade from Chromium 136 to Chromium 137
https://chromium.googlesource.com/chromium/src/+log/136.0.7103.93..137.0.7151.16?pretty=fuller&n=10000
QA tests
This is a major Chromium version bump, please do full passes.
Desktop Affected areas:
iOS Affected areas:
Android Affected areas:
The text was updated successfully, but these errors were encountered: