Skip to content

[C136] Tab group panel is not displayed with bottom toolbar #45548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 6 tasks
AlexeyBarabash opened this issue Apr 17, 2025 · 2 comments · Fixed by brave/brave-core#28728
Closed
1 of 6 tasks

[C136] Tab group panel is not displayed with bottom toolbar #45548

AlexeyBarabash opened this issue Apr 17, 2025 · 2 comments · Fixed by brave/brave-core#28728
Assignees

Comments

@AlexeyBarabash
Copy link
Contributor

Description

This is cr136 regression.

Reported by @hffvld

Steps to reproduce

  1. Ensure bottom toolbar is enabled
  2. Open some website
  3. Open some link by option Open in new tab in group

Actual result

There is no tab group panel above the bottom toolbar.

Expected result

Should be a tab group panel above the bottom toolbar.

Reproduces how often

Easily reproduced

Brave version

1.79.74

Device

  • Brand/model: any
  • Android version: any

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@AlexeyBarabash AlexeyBarabash added OS/Android Fixes related to Android browser functionality QA/Yes release-notes/exclude regression labels Apr 17, 2025
@AlexeyBarabash AlexeyBarabash self-assigned this Apr 17, 2025
@brave-builds brave-builds added this to the 1.79.x - Nightly milestone Apr 18, 2025
@kjozwiak kjozwiak changed the title Tab group panel is not displayed with bottom toolbar [C136] Tab group panel is not displayed with bottom toolbar Apr 22, 2025
@kjozwiak
Copy link
Member

The above requires 1.78.88 or higher for 1.78.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 24, 2025
@hffvld
Copy link
Contributor

hffvld commented Apr 24, 2025

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 16 BP22.250325.007 release-keys
Brave build: 1.78.90 
Chromium: 136.0.7103.48 (Official Build) (64-bit) 

STEPS:

  1. Follow the STR/TP from [C136] Tab group panel is not displayed with bottom toolbar #45548 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the tab group panel is shown above the bottom toolbar.
  • Verified the same when bottom toolbar is disabled.
  • Verified the same when Only open links in current tab group is enabled and disabled.

Bottom toolbar On and Tab group Off Bottom toolbar On and Tab group On Bottom toolbar Off and Tab group Off Bottom toolbar Off and Tab group On
1 2 3 4
1 2 3 4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants