Skip to content

[NTP Next] ViewCounterService::RegisterPageView should be called for each page load #45849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zenparsing opened this issue May 5, 2025 · 0 comments
Open

[NTP Next] ViewCounterService::RegisterPageView should be called for each page load #45849

zenparsing opened this issue May 5, 2025 · 0 comments
Assignees
@zenparsing
Labels
feature/new-tab OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@zenparsing
Copy link

zenparsing commented May 5, 2025 •
edited
Loading

Currently RegisterPageView is only getting called when ViewCounterService::GetCurrentWallpaperForDisplay returns a non-null value. The value may be nullopt if the kNewTabPageShowBackgroundImage pref is false (i.e. if the user has disabled backgrounds completely).
@zenparsing zenparsing self-assigned this May 5, 2025
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/new-tab OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rebron @zenparsing