Skip to content

[ads] The links Clear Brave Ads data and Reset Brave Rewards data... are shown in both rewards enabled and not enabled state #46105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 6 tasks
GeetaSarvadnya opened this issue May 15, 2025 · 4 comments · Fixed by brave/brave-core#29085
Closed
1 of 6 tasks

[ads] The links Clear Brave Ads data and Reset Brave Rewards data... are shown in both rewards enabled and not enabled state #46105

GeetaSarvadnya opened this issue May 15, 2025 · 4 comments · Fixed by brave/brave-core#29085
Assignees
@aseren
Labels
feature/ads OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.79.x - Release

Comments

@GeetaSarvadnya
Copy link

Description

The links Clear Brave Ads data and Reset Brave Rewards data... are shown in both rewards enabled and not enabled state

Steps to reproduce

  1. Clean profile 1.80.63 CR 137 build
  2. Open brave://settings/clearBrowserData
  3. Observe both the links in all the three tabs Basic, Advanced and On exit

Actual result

The links Clear Brave Ads data and Reset Brave Rewards data... are shown in both rewards enabled and not enabled state

Example Example Example
Image Image Image

Expected result

One link should be shown in both rewards enabled and not enabled state

  • When rewards is not enabled the link Clear Brave Ads data should be shown

  • When rewards is enabled the link Reset Brave Rewards data... should be shown

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.80.63 Chromium: 137.0.7151.16 (Official Build) nightly (64-bit)
Revision 4039ff223bf531edfac812e85efe8e67e83c966c
OS Windows 10 Version 22H2 (Build 19045.5854)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @brave/qa-team @rebron @Miyayes @mkarolin
@github-project-automation github-project-automation bot moved this to New Issues in Brave Rewards May 15, 2025
@GeetaSarvadnya GeetaSarvadnya mentioned this issue May 15, 2025
Closed
This was referenced May 15, 2025
Merged
Merged
@github-project-automation github-project-automation bot moved this from New Issues to Done in Brave Rewards May 16, 2025
@brave-builds brave-builds added this to the 1.80.x - Nightly milestone May 16, 2025
@tmancey tmancey added this to Ads May 16, 2025
@github-project-automation github-project-automation bot moved this to New issues in Ads May 16, 2025
@tmancey tmancey moved this from New issues to To Do in Ads May 16, 2025
@aseren aseren moved this from To Do to In progress in Ads May 16, 2025
@mkarolin mkarolin mentioned this issue May 16, 2025
Merged
@aseren aseren changed the title The links Clear Brave Ads data and Reset Brave Rewards data... are shown in both rewards enabled and not enabled state [ads] The links Clear Brave Ads data and Reset Brave Rewards data... are shown in both rewards enabled and not enabled state May 16, 2025
@aseren aseren moved this from In progress to Done in Ads May 16, 2025
@aseren
Copy link

aseren commented May 16, 2025

During the sanity check it was found that Clear Ads Data... is broken, as it doesn't delete the data. So Clear Ads Data... fix also should be uplifted.

cc @btlechowski @mkarolin

@aseren
Copy link

aseren commented May 16, 2025

Clear ads data... fix issue is #46132

@btlechowski btlechowski mentioned this issue May 16, 2025
Closed
@kjozwiak
Copy link
Member

The above requires 1.79.109 or higher for 1.79.x verification 👍

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented May 19, 2025 •
edited
Loading

Verification PASSED on

Brave | 1.79.109 Chromium: 137.0.7151.27 (Official Build) beta (64-bit)
-- | --
Revision | 3be9649562915e4e3022d40bc734435a23343b8c
OS | Windows 10 Version 22H2 (Build 19045.5854)

  • Confirmed that the link Clear Brave Ads data shown when rewards is not enabled

  • Confirmed that the link Reset Brave Rewards data... shown when rewards is enabled

Rewards enabled state Rewards Not enabled state
Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
feature/ads OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
Ads
Status: Done
Milestone
1.79.x - Release
Development

Successfully merging a pull request may close this issue.

[cr137 follow up] Fixes rewards reset links in Clear Browsing Data. brave/brave-core
6 participants
@tmancey @kjozwiak @bsclifton @GeetaSarvadnya @brave-builds @aseren