Skip to content

[ads] NTT are not shown on 1.80.x #46112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
btlechowski opened this issue May 15, 2025 · 1 comment · Fixed by brave/brave-core#29094
Closed

[ads] NTT are not shown on 1.80.x #46112

btlechowski opened this issue May 15, 2025 · 1 comment · Fixed by brave/brave-core#29094
Assignees
@tmancey
Labels
feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes regression release-notes/exclude
Milestone
1.80.x - Beta

Comments

@btlechowski
Copy link

btlechowski commented May 15, 2025 •
edited
Loading

Description

Regression introduced by #45770

Reported by @srirambv

Steps to reproduce

  1. Clean profile
  2. Wait for NTT grace period
  3. Trigger NTT

Actual result

NTT images are not shown

Image

Expected result

NTT images are shown

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.80.69 Chromium: 137.0.7151.16 (Official Build) nightly (64-bit)
Revision f548c45a01c5e861ea61e9856647b5780f5cda10
OS Linux

cc @iambrianfung @aseren @tmancey
@btlechowski btlechowski added this to Ads May 15, 2025
@github-project-automation github-project-automation bot moved this to New issues in Ads May 15, 2025
@tmancey tmancey self-assigned this May 15, 2025
@tmancey tmancey added release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels May 15, 2025
@tmancey tmancey moved this from New issues to Review in Ads May 15, 2025
@tmancey tmancey mentioned this issue May 15, 2025
Merged
@github-project-automation github-project-automation bot moved this from Review to Done in Ads May 15, 2025
@brave-builds brave-builds added this to the 1.80.x - Nightly milestone May 15, 2025
@btlechowski
Copy link
Author

Verified with

Brave 1.80.73 Chromium: 137.0.7151.27 (Official Build) nightly (64-bit)
Revision d945e09f5b5c4497fc7d992d266a698e462a4d17
OS Linux

NTT

Verified NTTs are shown:

Image

events:

Image

RichNTT

Verified NTTs are shown:

Image

events:

Image

@tmancey tmancey changed the title NTT are not shown on 1.80.x [ads] NTT are not shown on 1.80.x May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes regression release-notes/exclude
Projects
Ads
Status: Done
Milestone
1.80.x - Beta
Development

Successfully merging a pull request may close this issue.

[ads] Fixes NTT are not shown on 1.80.x brave/brave-core
3 participants
@tmancey @btlechowski @brave-builds