Skip to content

Modify Chromium files to fix PIP behavior #2 #46128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simoarpe opened this issue May 16, 2025 · 4 comments · Fixed by brave/brave-core#29104
Closed

Modify Chromium files to fix PIP behavior #2 #46128

simoarpe opened this issue May 16, 2025 · 4 comments · Fixed by brave/brave-core#29104
Assignees
Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@simoarpe
Copy link

Related to brave/brave-core#27849

After latest Chromium update (cr137) the behavior of picture picture when watching YouTube videos has stopped working again.

This time is not an issue on YT website but it seems that something has changed on how Chromium handles the activity when it goes in background.
Triggering the PIP shows an empty screen. No crashes, no errors, audio keeps playing, but an empty screen appears that goes away only closing the activity.

Image

@simoarpe simoarpe self-assigned this May 16, 2025
@simoarpe simoarpe added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels May 16, 2025
@brave-builds brave-builds added this to the 1.80.x - Nightly milestone May 16, 2025
@bsclifton
Copy link
Member

bsclifton commented May 16, 2025

cc: @mkarolin @samartnik this will need an uplift when we uplift CR137 to 1.79.x

also cc: @kjozwiak

@kjozwiak
Copy link
Member

The above requires 1.79.109 or higher for 1.79.x verification 👍

@kjozwiak
Copy link
Member

cc: @mkarolin @samartnik this will need an uplift when we uplift CR137 to 1.79.x

also cc: @kjozwiak

@bsclifton brave/brave-core#29104 was added into brave/brave-core#29048 which was just merged/uplifted into 1.79.x.

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 20, 2025
@hffvld
Copy link
Contributor

hffvld commented May 22, 2025

Verified on Galaxy Z Fold 6 and Pixel 6 using version(s):

Device/OS: 
- Galaxy Z Fold 6 / q6quew-user 15 AP3A.240905.015.A2 release-keys
- Pixel 6 / oriole-user 15 BP1A.250405.007 release-keys
Brave build: 1.79.110
Chromium: 137.0.7151.27 (Official Build) beta (64-bit) 

Filed follow-up issue #46257

STEPS:

  1. Follow the STR/TP from Patch FullscreenHtmlApiHandlerBase to fix PIP brave-core#29104 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the video and audio are still playing in PiP mode when locking and unlocking a device.

Pixel 6 Galaxy Z Fold 6
Screencast Screencast
1 2

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants