Skip to content

Subclass ToolbarTablet instead of overriding the behavior by changing the superclass #46133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
6 tasks
samartnik opened this issue May 16, 2025 · 0 comments
Open
6 tasks

Subclass ToolbarTablet instead of overriding the behavior by changing the superclass #46133

samartnik opened this issue May 16, 2025 · 0 comments
Assignees
@samartnik
Labels
dev-concern OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon".

Comments

@samartnik
Copy link
Contributor

Description

To avoid direct patches of ToolbarTablet we should subclass it and make changes in our class instead. Issue related to brave/brave-core#29087

Steps to reproduce

  1. n/a

Actual result

n/a

Expected result

n/a

Reproduces how often

Easily reproduced

Brave version

n/a

Device

  • Brand/model: n/a
  • Android version: n/a

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@samartnik samartnik added dev-concern OS/Android Fixes related to Android browser functionality labels May 16, 2025
@timchilds timchilds added the priority/P4 Planned work. We expect to get to it "soon". label May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
dev-concern OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timchilds @samartnik