Skip to content

Add support for class renaming via bytecode #46141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 tasks
samartnik opened this issue May 16, 2025 · 1 comment
Open
6 tasks

Add support for class renaming via bytecode #46141

samartnik opened this issue May 16, 2025 · 1 comment
Assignees
Labels
OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon".

Comments

@samartnik
Copy link
Contributor

Description

To avoid majority of patches in Android xml resources, we should explore the possibility of renaming upstream class to something else and renaming Brave's version of that class to upstream's name. In theory it should pick up Brave's class with upsteam's name in xmls and no other patching will be required. This commit can be used as a starting point samartnik/brave-core@20266a5

Steps to reproduce

  1. n/a

Actual result

n/a

Expected result

n/a

Reproduces how often

Easily reproduced

Brave version

n/a

Device

  • Brand/model: n/a
  • Android version: n/a

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label May 16, 2025
@samartnik
Copy link
Contributor Author

cc @bridiver

@timchilds timchilds added the priority/P4 Planned work. We expect to get to it "soon". label May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

2 participants