Skip to content

[ads] BraveNewTabTakeoverInfobar @NullMarked code health #46146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aseren opened this issue May 16, 2025 · 0 comments · Fixed by brave/brave-core#29109
Closed

[ads] BraveNewTabTakeoverInfobar @NullMarked code health #46146

aseren opened this issue May 16, 2025 · 0 comments · Fixed by brave/brave-core#29109
Assignees
@aseren
Labels
dev-concern feature/ads OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.79.x - Release

Comments

@aseren
Copy link

aseren commented May 16, 2025

This is needed to fix presubmit errors/warnings. For more context see: #45541
@aseren aseren self-assigned this May 16, 2025
@aseren aseren added dev-concern feature/ads OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude labels May 16, 2025
@aseren aseren added this to Ads May 16, 2025
@github-project-automation github-project-automation bot moved this to New issues in Ads May 16, 2025
@aseren aseren changed the title [ads] BraveNewTabTakeoverInfobar NullMarked code health [ads] BraveNewTabTakeoverInfobar @NullMarked code health May 16, 2025
@aseren aseren mentioned this issue May 17, 2025
Merged
@aseren aseren moved this from New issues to In progress in Ads May 17, 2025
@aseren aseren moved this from In progress to Review in Ads May 17, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in Ads May 17, 2025
@brave-builds brave-builds added this to the 1.80.x - Nightly milestone May 17, 2025
@aseren aseren mentioned this issue May 17, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
dev-concern feature/ads OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Ads
Status: Done
Milestone
1.79.x - Release
Development

Successfully merging a pull request may close this issue.

[ads] BraveNewTabTakeoverInfobar @NullMarked code health brave/brave-core
2 participants
@brave-builds @aseren