Skip to content

Load NTP when creating split view with active tab #46191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #46000
simonhong opened this issue May 20, 2025 · 0 comments · Fixed by brave/brave-core#29124
Closed
Tracked by #46000

Load NTP when creating split view with active tab #46191

simonhong opened this issue May 20, 2025 · 0 comments · Fixed by brave/brave-core#29124
Assignees
@simonhong
Labels
OS/Desktop QA/No release-notes/exclude split view
Milestone
1.81.x - Nightly

Comments

@simonhong
Copy link
Member

simonhong commented May 20, 2025 •
edited
Loading

When split view is created with active tab via SideBySide feature, chromium's split view specific page(kChromeUISplitViewNewTabPageURL) is created.
but we want to create NTP (brave://newtab).
@simonhong simonhong self-assigned this May 20, 2025
@simonhong simonhong moved this to In progress in Front End May 20, 2025
@simonhong simonhong mentioned this issue May 20, 2025
Open
16 tasks
simonhong added a commit to brave/brave-core that referenced this issue May 20, 2025
@simonhong
Create NTP tab when split view is created with active tab
66da19d 
fix brave/brave-browser#46191

Uptream loads split view specific page when createing another tab.
We want to load NTP instead.

TEST=SplitViewLocationBarBrowserTest.URLShouldBeUpdated_WhenActiveTabChanges

1. launch browser with --enable-features=SideBySide
2. Select "Add tab to split view" from active tab's context menu
3. Check NTP is loaded in newly created tab
@simonhong simonhong mentioned this issue May 20, 2025
Merged
simonhong added a commit to brave/brave-core that referenced this issue May 20, 2025
@simonhong
Create NTP tab when split view is created with active tab
6a81a42 
fix brave/brave-browser#46191

Uptream loads split view specific page when createing another tab.
We want to load NTP instead.

TEST=SplitViewLocationBarBrowserTest.URLShouldBeUpdated_WhenActiveTabChanges

1. launch browser with --enable-features=SideBySide
2. Select "Add tab to split view" from active tab's context menu
3. Check NTP is loaded in newly created tab
simonhong added a commit to brave/brave-core that referenced this issue May 21, 2025
@simonhong
Load NTP when creating split view with active tab (#29124)
31aac3a 
fix brave/brave-browser#46191

Uptream loads split view specific page when createing another tab.
We want to load NTP instead.

TEST=SplitViewLocationBarBrowserTest.URLShouldBeUpdated_WhenActiveTabChanges

1. launch browser with --enable-features=SideBySide
2. Select "Add tab to split view" from active tab's context menu
3. Check NTP is loaded in newly created tab
@brave-builds brave-builds added this to the 1.81.x - Nightly milestone May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Desktop QA/No release-notes/exclude split view
Projects
Front End
Status: In progress
Milestone
1.81.x - Nightly
Development

Successfully merging a pull request may close this issue.

Load NTP when creating split view with active tab brave/brave-core
2 participants
@simonhong @brave-builds