Skip to content

Apply brave's split view resize area UI to BraveMultiContentsView #46194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #46000
simonhong opened this issue May 20, 2025 · 0 comments · Fixed by brave/brave-core#29154
Closed
Tracked by #46000

Apply brave's split view resize area UI to BraveMultiContentsView #46194

simonhong opened this issue May 20, 2025 · 0 comments · Fixed by brave/brave-core#29154
Assignees
@simonhong
Labels
OS/Desktop QA/No release-notes/exclude split view
Milestone
1.81.x - Nightly

Comments

@simonhong
Copy link
Member

simonhong commented May 20, 2025 •
edited
Loading

Replace MultiContentsResizeArea with SplitViewSeparator.
@simonhong simonhong mentioned this issue May 20, 2025
Open
16 tasks
@simonhong simonhong self-assigned this May 20, 2025
@simonhong simonhong moved this to In progress in Front End May 21, 2025
simonhong added a commit to brave/brave-core that referenced this issue May 21, 2025
@simonhong
Applied our resize area to BraveMultiContentsView
6e8f9a0 
fix brave/brave-browser#46194
@simonhong simonhong mentioned this issue May 21, 2025
Merged
simonhong added a commit to brave/brave-core that referenced this issue May 21, 2025
@simonhong
Applied our resize area to BraveMultiContentsView
3a17f86 
fix brave/brave-browser#46194
simonhong added a commit to brave/brave-core that referenced this issue May 22, 2025
@simonhong
Applied our resize area to BraveMultiContentsView
7a98ae6 
fix brave/brave-browser#46194
simonhong added a commit to brave/brave-core that referenced this issue May 22, 2025
@simonhong
Applied our resize area to BraveMultiContentsView
a29207b 
fix brave/brave-browser#46194

TEST=SideBySideEnabledBrowserTest.BraveMultiContentsViewTest
simonhong added a commit to brave/brave-core that referenced this issue May 26, 2025
@simonhong
Applied our resize area to BraveMultiContentsView (#29154)
ad4f43c 
fix brave/brave-browser#46194

Replaced MultiContentsResizeArea with SplitViewSeparator to use our resizer UI in BraveMultiContentsView.

TEST=SideBySideEnabledBrowserTest.BraveMultiContentsViewTest

Manual test
1. Launch browser with --enable-features=SidebySide
2. Open split view with any tab's context menu
3. Check our resize handle is used
@brave-builds brave-builds added this to the 1.81.x - Nightly milestone May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Desktop QA/No release-notes/exclude split view
Projects
Front End
Status: In progress
Milestone
1.81.x - Nightly
Development

Successfully merging a pull request may close this issue.

Applied our resize area to BraveMultiContentsView brave/brave-core
2 participants
@simonhong @brave-builds