Skip to content

f/u #34046 Remove password check box from Import dialog for Chrome #46206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 of 6 tasks
rebron opened this issue May 20, 2025 · 0 comments · May be fixed by brave/brave-core#29149
Open
3 of 6 tasks

f/u #34046 Remove password check box from Import dialog for Chrome #46206

rebron opened this issue May 20, 2025 · 0 comments · May be fixed by brave/brave-core#29149
Assignees
@mkarolin
Labels
feature/importer google OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. retention

Comments

@rebron
Copy link
Collaborator

rebron commented May 20, 2025

Description

Due to a change in Chrome #34046 (comment), user can't import passwords from Chrome via onboarding and via the Import dialog.

We'll need to remove the checkbox from the Import dialog for Chrome.

Steps to reproduce

  1. Open Brave and select Import bookmarks and settings from brave://settings/
  2. Select Chrome or a Chrome profile from the menu (Chrome should be installed on your machine)
  3. Notice the checkbox in the dialog.

Actual result

Image

Expected result

The checkbox for Saved Passwords should be hidden/removed from this dialog.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.78.x

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@rebron rebron added OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. feature/importer retention google labels May 20, 2025
@rebron rebron moved this to In progress in Settings May 20, 2025
@bsclifton bsclifton assigned mkarolin and unassigned bsclifton May 20, 2025
@mkarolin mkarolin linked a pull request May 20, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
feature/importer google OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. retention
Projects
Settings
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hides Passwords checkbox in import dialog for Chrome. brave/brave-core
3 participants
@bsclifton @rebron @mkarolin