Skip to content

Email Aliases: implement GenerateAlias error message #46222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arthuredelstein opened this issue May 21, 2025 · 1 comment · Fixed by brave/brave-core#29153
Closed

Email Aliases: implement GenerateAlias error message #46222

arthuredelstein opened this issue May 21, 2025 · 1 comment · Fixed by brave/brave-core#29153
Assignees
@arthuredelstein
Labels
OS/Desktop privacy/feature/email-aliases QA/Yes release-notes/exclude
Milestone
1.81.x - Nightly

Comments

@arthuredelstein
Copy link

Platforms

Linux, macOS, Windows

Description

We want GenerateAlias() => (string? alias_email, string? error_message);
and it should display the error message in the appropriate place in the UI.

Plus unit tests
@arthuredelstein arthuredelstein self-assigned this May 21, 2025
@arthuredelstein arthuredelstein mentioned this issue May 21, 2025
Merged
@arthuredelstein arthuredelstein changed the title Email Alaises: implement generateAlias error message Email Aliases: implement generateAlias error message May 21, 2025
@arthuredelstein arthuredelstein changed the title Email Aliases: implement generateAlias error message Email Aliases: implement GgenerateAlias error message May 21, 2025
@arthuredelstein arthuredelstein changed the title Email Aliases: implement GgenerateAlias error message Email Aliases: implement GenerateAlias error message May 21, 2025
@brave-builds brave-builds added this to the 1.81.x - Nightly milestone May 22, 2025
@arthuredelstein
Copy link
Author

QA testing

  1. Go to npm run storybook > Email Aliases > Settings Page
  2. Click on "New Alias"
  3. Click the refresh button a few times. Sometimes an error message will be displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthuredelstein arthuredelstein

Labels
OS/Desktop privacy/feature/email-aliases QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.81.x - Nightly
Development

Successfully merging a pull request may close this issue.

Email Aliases: error message for GenerateAlias brave/brave-core
3 participants
@arthuredelstein @rebron @brave-builds