Skip to content

Brockit is removing the empty line in package.json #46229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cdesouza-chromium opened this issue May 21, 2025 · 0 comments · Fixed by brave/brave-core#29155
Closed

Brockit is removing the empty line in package.json #46229

cdesouza-chromium opened this issue May 21, 2025 · 0 comments · Fixed by brave/brave-core#29155
Assignees
@cdesouza-chromium
Labels
dev-concern OS/Desktop QA/No QA/Test-Plan-Specified release-notes/exclude
Milestone
1.79.x - Release

Comments

@cdesouza-chromium
Copy link
Contributor

This has been noticed lately, and it tends to cause presubmit failures.
@cdesouza-chromium cdesouza-chromium self-assigned this May 21, 2025
cdesouza-chromium added a commit to brave/brave-core that referenced this issue May 21, 2025
@cdesouza-chromium
[canary] Stop removing empty line in package.json
6f731ae 
This for some reason only started being an issue now, but basically we
have to make sure that an empty line is left at the end of
`package.json`, otherwise we get presubmit failures.

Resolves brave/brave-browser#46229
@cdesouza-chromium cdesouza-chromium mentioned this issue May 21, 2025
Merged
@brave-builds brave-builds added this to the 1.80.x - Nightly milestone May 21, 2025
cdesouza-chromium added a commit to brave/brave-core that referenced this issue May 21, 2025
@cdesouza-chromium
[canary] Stop removing empty line in package.json
255e30e 
This for some reason only started being an issue now, but basically we
have to make sure that an empty line is left at the end of
`package.json`, otherwise we get presubmit failures.

Resolves brave/brave-browser#46229
@cdesouza-chromium cdesouza-chromium mentioned this issue May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdesouza-chromium cdesouza-chromium

Labels
dev-concern OS/Desktop QA/No QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
1.79.x - Release
Development

Successfully merging a pull request may close this issue.

[canary] Stop removing empty line in package.json brave/brave-core
2 participants
@cdesouza-chromium @brave-builds