Skip to content

MacOS build fails on master #46234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkarolin opened this issue May 21, 2025 · 0 comments · Fixed by brave/brave-core#29158
Closed

MacOS build fails on master #46234

mkarolin opened this issue May 21, 2025 · 0 comments · Fixed by brave/brave-core#29158

Comments

@mkarolin
Copy link
Contributor

mkarolin commented May 21, 2025

Builds fail on CI with the following error:

FAILED: gen/ui/webui/resources/resources_grit.d.stamp gen/ui/webui/resources/grit/webui_resources.h gen/ui/webui/resources/grit/webui_resources_map.cc gen/ui/webui/resources/grit/webui_resources_map.h gen/ui/webui/resources/webui_resources.pak gen/ui/webui/resources/webui_resources.pak.info
python3 ../../tools/grit/grit.py -i gen/ui/webui/resources/webui_resources.grd build -o gen/ui/webui/resources --depdir . --depfile gen/ui/webui/resources/resources_grit.d --write-only-new=1 --depend-on-stamp -D DEVTOOLS_GRD_PATH=gen/third_party/devtools-frontend/src/front_end/devtools_resources -D SHARED_INTERMEDIATE_DIR=gen -D _google_chrome=false -D _is_chrome_for_testing_branded=false -D chromeos_ash=false -D reven=false -D toolkit_views=true -D use_aura=false -D use_ozone=false -D use_titlecase=true -D is_desktop_android=false -D scale_factors=2x -E branding_path_component=brave -E root_gen_dir=gen -E root_src_dir=../../ -E CHROMIUM_BUILD=chromium -E add_filepath_to_resource_map=false -f gen/tools/gritsettings/default_resource_ids -p ../../tools/gritsettings/startup_resources_mac.txt --assert-file-list obj/ui/webui/resources/resources_expected_outputs.txt
Traceback (most recent call last):
File "/Users/jenkins/jenkins/workspace/brave-browser-build-macos-x64-nightly/src/out/Release/../../tools/grit/grit.py", line 17, in
sys.exit(grit.grit_runner.Main(sys.argv[1:]))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/jenkins/jenkins/workspace/brave-browser-build-macos-x64-nightly/src/tools/grit/grit/grit_runner.py", line 313, in Main
return toolobject.Run(options, args[1:])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/jenkins/jenkins/workspace/brave-browser-build-macos-x64-nightly/src/tools/grit/grit/tool/build.py", line 271, in Run
self.Process()
File "/Users/jenkins/jenkins/workspace/brave-browser-build-macos-x64-nightly/src/tools/grit/grit/tool/build.py", line 387, in Process
self.res.InitializeIds()
File "/Users/jenkins/jenkins/workspace/brave-browser-build-macos-x64-nightly/src/tools/grit/grit/node/misc.py", line 682, in InitializeIds
self._id_map = _ComputeIds(self, predetermined_id_map)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/jenkins/jenkins/workspace/brave-browser-build-macos-x64-nightly/src/tools/grit/grit/node/misc.py", line 250, in _ComputeIds
check_group_count()
File "/Users/jenkins/jenkins/workspace/brave-browser-build-macos-x64-nightly/src/tools/grit/grit/node/misc.py", line 140, in check_group_count
raise exception.IdRangeOverflow(msg)
grit.exception.IdRangeOverflow: ID range overflow.: Generated .grd file used more IDs (1132) than were allocated for it (1131) for type includes. You need to update ../../../../gen/tools/gritsettings/default_resource_ids for this .grd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants