Skip to content

[ads] Add SmartNTT virtual prefs support on iOS #46238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aseren opened this issue May 21, 2025 · 1 comment · Fixed by brave/brave-core#29161
Closed

[ads] Add SmartNTT virtual prefs support on iOS #46238

aseren opened this issue May 21, 2025 · 1 comment · Fixed by brave/brave-core#29161
Assignees
@aseren
Labels
bug feature/ads OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude
Milestone
1.81.x - Nightly

Comments

@aseren
Copy link

aseren commented May 21, 2025 •
edited
Loading

Virtual prefs description:
https://docs.google.com/document/d/1JZVxdYVoHypR_dxJO73mpuB4i8WJZNSmzuFjYPeHxaY/edit?tab=t.0#heading=h.vrco4m7g1pco
@aseren aseren self-assigned this May 21, 2025
@aseren aseren added this to Ads May 21, 2025
@aseren aseren added bug priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude feature/ads OS/iOS Fixes related to iOS browser functionality labels May 21, 2025
@github-project-automation github-project-automation bot moved this to New issues in Ads May 21, 2025
@aseren aseren moved this from New issues to In progress in Ads May 21, 2025
@aseren aseren mentioned this issue May 21, 2025
Merged
@aseren aseren changed the title [ads] Add virtual prefs support on iOS [ads] Add SmartNTT virtual prefs support on iOS May 23, 2025
@aseren
Copy link
Author

aseren commented May 25, 2025 •
edited
Loading

The fix PR introduces VirtualPrefProviderDelegate and VirtualPrefProviderDelegateIOS classes which are located in different targets.
They should be moved to one target and implemented as a free function as part of AdsService iOS and Desktop unification here: #33868

@aseren aseren moved this from In progress to Review in Ads May 25, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in Ads May 26, 2025
@brave-builds brave-builds added this to the 1.81.x - Nightly milestone May 26, 2025
This was referenced May 26, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
bug feature/ads OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude
Projects
Ads
Status: Done
Milestone
1.81.x - Nightly
Development

Successfully merging a pull request may close this issue.

[ads] Add SmartNTT virtual prefs support on iOS brave/brave-core
2 participants
@brave-builds @aseren