Skip to content

Seeing domain blocked interstitial on Amazon.com with Chromium web embedder flag enabled #46239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 5 tasks
StephenHeaps opened this issue May 21, 2025 · 1 comment · Fixed by brave/brave-core#29177
Closed
1 of 5 tasks
Assignees
Labels
Milestone

Comments

@StephenHeaps
Copy link

StephenHeaps commented May 21, 2025

Description

Visiting Amazon.com in aggressive mode with the #brave-use-chromium-web-embedder flag enabled will redirect to our domain blocked interstitial (The domain blocked interstitial is only shown in aggressive mode).

Steps to reproduce

  1. Enable chromium web views feature flag #brave-use-chromium-web-embedder and then relaunch the app.
  2. Set to aggressive mode for Trackers & Ads Blocking in Settings > Shields & Privacy
  3. Visit Amazon.com

Actual result

Blocked domain interstitial is shown:

Expected result

No interstitial shown for non-main frame navigation requests

Reproduces how often

Easily reproduced

Brave version

1.80

Device/iOS version

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

Internally target_frame_is_main is false:
Image

However this value is not exposed to us to use, so we check PageTransitionIsMainFrame which instead returns true for this request so we treat it as a main frame request and show the interstitial.

Thread:
https://bravesoftware.slack.com/archives/C06UXF3KJ/p1747836136245669

@kjozwiak
Copy link
Member

The above requires 1.80.93 or higher for 1.80.x verification 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants