Skip to content

[Zcash] Zcash native token may not be displayed on some wallets #46306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6 tasks
cypt4 opened this issue May 23, 2025 · 3 comments · Fixed by brave/brave-core#29198
Closed
6 tasks

[Zcash] Zcash native token may not be displayed on some wallets #46306

cypt4 opened this issue May 23, 2025 · 3 comments · Fixed by brave/brave-core#29198
Assignees
@cypt4
Labels
feature/web3/wallet/core feature/web3/wallet/zcash feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.79.x - Release

Comments

@cypt4
Copy link

cypt4 commented May 23, 2025

Description

Some old wallets may have an issue that zcash native transparent token is not displayed after zcash shield feature is enabled.

Steps to reproduce

  1. There should be an old profile wallet created before zcash transparent support.
  2. Enable zcash shielded support feature
  3. Check whether transparent funds are displayed
    OR
    Cleanup zcash native tokens in the brave.wallet.wallet_user_assets_list preference

Actual result

Transparent balance is not displayed

Expected result

Transparent balance should be displayed

Reproduces how often

Easily reproduced

Desktop Brave version (brave://version info)

1.78+

Android device

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@cypt4 cypt4 added OS/Android Fixes related to Android browser functionality OS/Desktop labels May 23, 2025
@cypt4 cypt4 self-assigned this May 23, 2025
@cypt4 cypt4 added this to Web3 May 23, 2025
@cypt4 cypt4 added priority/P2 A bad problem. We might uplift this to the next planned release. feature/web3/wallet/zcash labels May 23, 2025
cypt4 added a commit to brave/brave-core that referenced this issue May 23, 2025
@cypt4
[ZCash] Fix ZEC native tokens
dbe3482 
Resolves brave/brave-browser#46306
@cypt4 cypt4 mentioned this issue May 23, 2025
Merged
cypt4 added a commit to brave/brave-core that referenced this issue May 23, 2025
@cypt4
[ZCash] Fix ZEC native tokens
c37cfae 
Resolves brave/brave-browser#46306
cypt4 added a commit to brave/brave-core that referenced this issue May 23, 2025
@cypt4
[ZCash] Fix ZEC native tokens (#29198)
6cbd0be 
* [ZCash] Fix ZEC native tokens
Resolves brave/brave-browser#46306
@github-project-automation github-project-automation bot moved this to Done in Web3 May 23, 2025
@brave-builds brave-builds added feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core labels May 23, 2025
@brave-builds brave-builds added this to the 1.81.x - Nightly milestone May 23, 2025
This was referenced May 23, 2025
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.79.115 or higher for 1.79.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.79.115 Chromium: 137.0.7151.44 (Official Build) (64-bit)
Revision 50197557e46124a212479f9135d16b2cbe238a97
OS Windows 11 Version 24H2 (Build 26100.3775)
  • Verified steps from PR description
  • Verified with brave://flags/#brave-wallet-zcash flag set to Enabled - Shielded support enabled, restoring wallet shows correct balance for both Transparent and Shielded account
  • Verified with brave://flags/#brave-wallet-zcash flag set to Enabled - Shielded support enabled, creating new wallet shows correct balance for both Transparent and Shielded account
  • Verified with brave://flags/#brave-wallet-zcash flag set to Enabled - Shielded support disabled, restoring wallet shows correct balance for Transparent account and no Shielded account balance
  • Verified with brave://flags/#brave-wallet-zcash flag set to Enabled - Shielded support disabled, new wallet shows zero balance
46306-1.mp4
46306-2.mp4

@rebron rebron changed the title [ZCash] ZCash native token may not be displayed on some wallets [Zcash] Zcash native token may not be displayed on some wallets May 27, 2025
@srirambv
Copy link
Contributor

Verification passed on Google Pixel 8 with Android 15 running

Brave 1.79.115 Chromium: 137.0.7151.44 (Official Build) (64-bit)
Revision 50197557e46124a212479f9135d16b2cbe238a97
OS Android 15; Build/BP1A.250505.005.B1; 35; REL
  • Verified steps from brave/brave-core#29198
  • Verified ZCash flag is Disabled by default
  • Verified with brave://flags/#brave-wallet-zcash flag set to Enabled - Shielded support enabled, restoring wallet shows correct balance for both Transparent and Shielded account
  • Verified with brave://flags/#brave-wallet-zcash flag set to Enabled - Shielded support enabled, creating new wallet shows correct balance for both Transparent and Shielded account
  • Verified with brave://flags/#brave-wallet-zcash flag set to Enabled - Shielded support disabled, restoring wallet shows correct balance for Transparent account and no Shielded account balance
  • Verified with brave://flags/#brave-wallet-zcash flag set to Enabled - Shielded support disabled, new wallet shows zero balance

@LaurenWags LaurenWags mentioned this issue May 28, 2025
Closed
@hffvld hffvld mentioned this issue May 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/wallet/core feature/web3/wallet/zcash feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Status: Done
Milestone
1.79.x - Release
Development

Successfully merging a pull request may close this issue.

[ZCash] Fix ZEC native tokens brave/brave-core
4 participants
@kjozwiak @srirambv @brave-builds @cypt4