Skip to content

Commit d272540

Browse files
authored
Fix network pattern checking (#28174)
* Fix network pattern checking Fixes brave/brave-browser#44717
1 parent 0b54a1a commit d272540

File tree

2 files changed

+35
-4
lines changed

2 files changed

+35
-4
lines changed

browser/net/brave_static_redirect_network_delegate_helper.cc

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,11 @@ int OnBeforeURLRequest_StaticRedirectWorkForGURL(
8888
URLPattern::SCHEME_HTTP | URLPattern::SCHEME_HTTPS,
8989
kWidevineGoogleDlPrefix);
9090

91+
if (widevine_gvt1_pattern->MatchesURL(request_url) ||
92+
widevine_google_dl_pattern->MatchesURL(request_url)) {
93+
return net::OK;
94+
}
95+
9196
if (geo_pattern->MatchesURL(request_url)) {
9297
*new_url = GURL(BUILDFLAG(GOOGLEAPIS_URL));
9398
return net::OK;
@@ -156,16 +161,15 @@ int OnBeforeURLRequest_StaticRedirectWorkForGURL(
156161
*new_url = request_url.ReplaceComponents(replacements);
157162
return net::OK;
158163
}
159-
if (gvt1_pattern->MatchesURL(request_url) &&
160-
!widevine_gvt1_pattern->MatchesURL(request_url)) {
164+
165+
if (gvt1_pattern->MatchesURL(request_url)) {
161166
replacements.SetSchemeStr("https");
162167
replacements.SetHostStr(kBraveRedirectorProxy);
163168
*new_url = request_url.ReplaceComponents(replacements);
164169
return net::OK;
165170
}
166171

167-
if (googleDl_pattern->MatchesURL(request_url) &&
168-
!widevine_google_dl_pattern->MatchesURL(request_url)) {
172+
if (googleDl_pattern->MatchesURL(request_url)) {
169173
replacements.SetSchemeStr("https");
170174
replacements.SetHostStr(kBraveRedirectorProxy);
171175
*new_url = request_url.ReplaceComponents(replacements);

browser/net/brave_static_redirect_network_delegate_helper_unittest.cc

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,19 @@ TEST(BraveStaticRedirectNetworkDelegateHelperTest, DontModifyGvt1ForWidevine) {
275275
EXPECT_EQ(rc, net::OK);
276276
}
277277

278+
TEST(BraveStaticRedirectNetworkDelegateHelperTest, DontModifyGvt1ForWidevine2) {
279+
const GURL url(
280+
"http://r2---sn-n4v7sn7y.gvt1.com/edgedl/release2/chrome_component/"
281+
"adpwdrehowm2a6w7spq52lx3eyla_4.10.2891.0/"
282+
"oimompecagnajdejgnnjijobebaeigek_4.10.2891.0_mac_arm64_"
283+
"adebp6igda2i2udepjmfqykgfjja.crx3");
284+
auto request_info = std::make_shared<brave::BraveRequestInfo>(url);
285+
int rc =
286+
OnBeforeURLRequest_StaticRedirectWork(ResponseCallback(), request_info);
287+
EXPECT_EQ(request_info->new_url_spec, "");
288+
EXPECT_EQ(rc, net::OK);
289+
}
290+
278291
TEST(BraveStaticRedirectNetworkDelegateHelperTest,
279292
DontModifyGoogleDlForWidevine) {
280293
const GURL url(
@@ -289,6 +302,20 @@ TEST(BraveStaticRedirectNetworkDelegateHelperTest,
289302
EXPECT_EQ(rc, net::OK);
290303
}
291304

305+
TEST(BraveStaticRedirectNetworkDelegateHelperTest,
306+
DontModifyGoogleDlForWidevine2) {
307+
const GURL url(
308+
"http://dl.google.com/edgedl/release2/chrome_component/"
309+
"adpwdrehowm2a6w7spq52lx3eyla_4.10.2891.0/"
310+
"oimompecagnajdejgnnjijobebaeigek_4.10.2891.0_mac_arm64_"
311+
"adebp6igda2i2udepjmfqykgfjja.crx3");
312+
auto request_info = std::make_shared<brave::BraveRequestInfo>(url);
313+
int rc =
314+
OnBeforeURLRequest_StaticRedirectWork(ResponseCallback(), request_info);
315+
EXPECT_EQ(request_info->new_url_spec, "");
316+
EXPECT_EQ(rc, net::OK);
317+
}
318+
292319
TEST(BraveStaticRedirectNetworkDelegateHelperTest,
293320
ModifySafeBrowsingFileCheckURL) {
294321
brave::SetSafeBrowsingEndpointForTesting(true);

0 commit comments

Comments
 (0)