Skip to content

New Tab Takeover infobar notice and Learn More link (uplift to 1.78.x) #28836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Apr 25, 2025

Uplift of #28597
Resolves brave/brave-browser#45028

Uplift of #28203
Resolves brave/brave-browser#44766

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@aseren aseren requested a review from a team as a code owner April 25, 2025 17:51
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Apr 25, 2025
@brave-builds
Copy link
Collaborator

Note

You have got a presubmit notification. No action required.

-------------------------
[Info] chromium_src:
Located 2 #define statements.

@brave-builds
Copy link
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

  android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java:318: Use SharedPreferencesManager instead to access app-wide SharedPreferences from //src/chrome.
  android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java:940: Use SharedPreferencesManager instead to access app-wide SharedPreferences from //src/chrome.
  android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java:1426: If possible, please use #setTextAppearance to set one of the pre-defined text appearance styles in src/ui/android/java/res/values-v17/styles.xml, instead of using #setTextColor or #setTextSize. This will ensure that your programmatically set text styles stay in-sync with text styles used in the rest of Chrome. (crbug.com/775198)

@brave-builds
Copy link
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.


Please add @NullMarked and fix the NullAway warnings in the following files
(see https://chromium.googlesource.com/chromium/src/+/main/styleguide/java/nullaway.md):

Items:

android/java/org/chromium/chrome/browser/infobar/BraveInfoBarIdentifier.java
android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java
android/java/org/chromium/chrome/browser/ntp/BraveNewTabTakeoverInfobar.java
android/java/org/chromium/chrome/browser/settings/BackgroundImagesPreferences.java

@brave-builds
Copy link
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

Found 1 lines longer than 80 characters (first 5 shown).

Items:

android/java/res/xml/background_images_preferences.xml, line 26, 88 chars

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing the above as discussed via Slack. @tmancey mentioned the above was discussed in the ads meeting and 1.79.x should be fine for the above.

@kjozwiak kjozwiak closed this Apr 28, 2025
@kjozwiak kjozwiak deleted the issues/45028_1.78.x branch April 28, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants